Re: RFS: mandos (updated package)
-----BEGIN PGP SIGNED MESSAGE-----
George Danchev <email@example.com> writes:
> Fixing bugs is always nice idea and in fact your new version brings
> notable improvements compared to the version in sid. However, while
> checking your new package, I also decided check cppcheck correctness
>  with mandos sources, so it brought my attention to a potential
> memleak (see patch below) -- memory is not released within that
> function and there are no chances left to the caller to free it our
> since NULL is returned.
Wow, that's a *nice* catch! Thank you!
I'm happy to note that the problem was not large; the memory leak
could only happen if malloc() had failed, and the leaking function is
called a limited number of times, so it's not an unbounded leak.
Still, nice catch.
> I guess we are better off to fixing that before uploading ?
Sure. We just did a new release with your fix included, and I will
now go and post a new RFS here on debian-mentors.
The Mandos Project
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
-----END PGP SIGNATURE-----