Re: RFS: libpam-paperauth
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On Mon, Jan 5, 2009 at 10:06 PM, Matt Arnold <mattarnold5@gmail.com> wrote:
>
> I am the original ITPer of this package and for the benefit of
> - -mentors I had to drop it due to lack of time. I am glad that someone
> has picked this up. However your package fails to build from source with
> a docbook error, you should always test in pbuilder before you upload.
Odd, I just tried building in pbuilder (intrepid host with sid chroot)
and did not have any problems. What's the error message you are
getting?
> Also NEW packages should always have a debian revision of -1.
Per http://people.debian.org/~codehelp/#increment, I've incremented
the revision each time I've made an upload to allow programs like
interdiff etc to work. If needed, I can re-merge the changes into 1
prior to my sponsor's Debian upload.
>
> In debian/rules you reference simple-patchsys but you have changes directly
> in the diff.gz, not a mortal sin but it is considered best practice to
> use a patch system.
I'll see about converting to a patchsystem, but last time I tried I
got odd errors from cdbs-edit-patch.
- -lf
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
iEYEARECAAYFAkljZIoACgkQtrC51grHAgbk1QCgssDN9Iw4GPS046/PeNQNk0PE
1LEAoIH9jEOdA2J8S/LY47s2O4xXY0vM
=zbRt
-----END PGP SIGNATURE-----
Reply to: