[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: lottanzb



Hi Severin

On Mon, Jan 05, 2009 at 10:25:46PM +0100, Severin Heiniger wrote:
> I am looking for a sponsor for my package "lottanzb".

IANADD and can't upload for you, sorry. But some general bits you could
improve:

Lintian generates a minor and some wishlist, full texts attached:

I: lottanzb source: debian-watch-file-is-missing
I: lottanzb source: build-depends-without-arch-dep python-kiwi
I: lottanzb: package-contains-empty-directory
usr/share/icons/hicolor/scalable/apps/
I: lottanzb: copyright-with-old-dh-make-debian-copyright

You don't need debian/dirs; setup.py will create usr/bin for you.

Don't include all of upstream's changes in your changelog, and you don't
need to include your previous versions if they were never in the Debian
archive. Just mark this version as 'Initial release' and close your ITP
on it.

You do need to install upstream's changelog into
usr/share/doc/lottanzb/changelog, I'm not familiar with CDBS but with
Debhelper dh_installchangelogs will take care of this automatically for
you.

(In fact you could use debhelper 7 and its tiny rules file, instead of
the overhead of including CDBS at all, because upstream's install
process is just fine. See [1], [2].)

In debian/control you don't need to depend on ${shlibs:Depends} as this
is a binary-independent package. Standards version 3.8 also recommends a
Homepage field. You have a version dependency on python-kiwi in the
binary depends, but not for build-depends, is there any reason for this?

Your manual page has something wrong with the line breaks in the author
section. Use "man -l debian/lottanzb.1" to preview it and you'll see
the paragraph is all run together with "br." in between sentences.

You might want to revise your short description a bit and make it clear
that this is for downloading newsbins, not reading newsgroups.

Just little things, but that will make your package all the more ready
for a sponsor to upload.

[1] http://manpage.fr/man1/dh
[2] /usr/share/doc/debhelper/examples/rules.tiny


-- 
Jonathan Wiltshire

PGP/GPG: 0xDB800B52 / 4216 F01F DCA9 21AC F3D3  A903 CA6B EA3E DB80 0B52
Sending of encrypted mail is encouraged

I: lottanzb source: debian-watch-file-is-missing
N: 
N:    This source package is not Debian-native but it does not have a
N:    debian/watch file. This file is used for automatic detection of new
N:    upstream versions by the Debian External Health Status project and other
N:    project infrastructure. If this package is maintained upstream, please
N:    consider adding a debian/watch file to detect new releases.
N:    
N:    If the package is not maintained upstream or if upstream uses a
N:    distribution mechanism that cannot be meaningfully monitored by uscan
N:    and the Debian External Health Status project, please consider adding a
N:    debian/watch file containing only comments documenting the situation.
N:    
N:    Refer to Debian Policy Manual section 4.11 (Optional upstream source
N:    location: debian/watch) and the uscan(1) manual page for details.
N:    
N:    Severity: wishlist; Certainty: certain
N: 
I: lottanzb source: build-depends-without-arch-dep python-kiwi
N: 
N:    The control file lists the given package in Build-Depends, but no
N:    architecture-dependent packages are built. If all the packages built are
N:    architecture-independent, the only packages that should be listed in
N:    Build-Depends are those required to run the clean target (such as
N:    debhelper if you use dh_clean). Other build dependencies should be
N:    listed in Build-Depends-Indep instead.
N:    
N:    Refer to Debian Policy Manual section 7.7 (Relationships between source
N:    and binary packages - Build-Depends, Build-Depends-Indep,
N:    Build-Conflicts, Build-Conflicts-Indep) for details.
N:    
N:    Severity: minor; Certainty: possible
N: 
I: lottanzb: package-contains-empty-directory usr/share/icons/hicolor/scalable/apps/
N: 
N:    This package installs an empty directory. This might be intentional but
N:    it's normally a mistake. If it is intentional, add a lintian override.
N:    
N:    If a package ships with or installs empty directories, you can remove
N:    them in debian/rules by calling:
N:    
N:     $ find path/to/base/dir -type d -empty -delete
N:    
N:    Severity: wishlist; Certainty: certain
N: 
I: lottanzb: copyright-with-old-dh-make-debian-copyright
N: 
N:    The copyright file contains the incomplete Debian packaging copyright
N:    boilerplate from older versions of dh_make. (C) is not considered as a
N:    valid way to express the copyright ownership. The word Copyright or the
N:    © symbol should be used instead or in addition to (C).
N:    
N:    Severity: wishlist; Certainty: certain
N: 

Attachment: signature.asc
Description: Digital signature


Reply to: