Re: RFS: krypt
On Wed, Dec 31, 2008 at 10:09 AM, Stefanos Harhalakis <v13@v13.gr> wrote:
> The upload would fix these bugs: 507655, 510275
Firstly, there was no need to file 510275, instead you should have
just retitled the RFP 507655 to ITP and marked yourself as the owner.
Please read these:
http://www.debian.org/devel/wnpp/#l3
http://www.debian.org/Bugs/server-control#retitle
http://www.debian.org/Bugs/server-control#owner
Secondly, I've merged them and retitled 507655. So you only need to
close one and the other will be closed too.
> - dget http://mentors.debian.net/debian/pool/main/k/krypt/krypt_0.2-1.dsc
Quick review of the diff.gz:
debian/watch needn't have blank lines or comments.
Please forward the manual page upstream if you have not already.
Post-lenny, kde3/qt3 will be transitioned away from, so it might be a
good idea to ask upstream to port the app to KDE 4 & Qt 4. Same for
the HAL -> DeviceKit transition.
debian/rules contains a lot of unnessecary comments and stuff.
debian/rules doesn't handle DEB_BUILD_OPTIONS=noopt or
DEB_BUILD_OPTIONS=parallel (see debian-policy for info about these).
debian/rules runs dh_installexamples but there are no debian/*examples files
since you are depending on debhelper 7 and using compat 7, perhaps you
should be using features from it? see the dh manual page,
/usr/share/doc/debhelper/examples/rules.simple and
/usr/share/doc/debhelper/examples/rules.tiny.
--
bye,
pabs
http://wiki.debian.org/PaulWise
Reply to: