Re: RFS: nast (adopting package, fixing important bug)
Hello Ryan,
On Wed, Dec 10, 2008 at 09:18, Ryan Niebur <ryanryan52@gmail.com> wrote:
> Dear mentors,
>
> I am looking for a sponsor for the new version 0.2.0-5
> of my package "nast".
Here are my comments:
- why are config.sub,guess changed in the diff.gz? If you replace
them, please rm them in the clean target ( there is no need to save
them in debian/ dir: removeing a file present in the upstream tarball,
will avoid its changes to appear in the diff, but the file will still
be present when unpacking since it's in orig.tar.gz)
- 3.8.0 request the Homepage field in source stanza of debian/control
- you can remove "see COPYING file for details." from
debian/copyright; it's always better to refer to GPL-2 local file for
GPLv2+ software
- please forward the patches upstream (if you haven't done so yet)
- the list of featurs has too much space at the beginning of the line:
please only use 2 spaces (so that packages.d.o will show the list in
verbatim)
- clarify the license of debian packaging
- debian/dirs is probably not needed, look if you can remove
- can't you use dh_installman to install manpage instead of do it "by hand"?
- remove all the commented/not needed dh_* calls
- please include a description (eventually the author too) in the
patches, as even lintian signals:
W: nast source: quilt-patch-missing-description
- manpage has still many warnings:
I: nast: hyphen-used-as-minus-sign
Once fixed, please reupload (same debian revision) and reply to this email
Regards,
--
Sandro Tosi (aka morph, Morpheus, matrixhasu)
My website: http://matrixhasu.altervista.org/
Me at Debian: http://wiki.debian.org/SandroTosi
Reply to: