Hi Dne Wed, 29 Oct 2008 19:07:34 +0000 "David Futcher" <bobbo@ubuntu.com> napsal(a): > On 29/10/2008, Michal Čihař <nijel@debian.org> wrote: > > > > Lintian -I: > > > > I: bzr-diffstat source: debian-watch-file-is-missing > > I: bzr-diffstat: package-contains-empty-directory usr/bin/ > > I: bzr-diffstat: package-contains-empty-directory usr/sbin/ > > > Extra directories removed. The package is based completely on bzr > checkouts, how should I write a watchfile for this? I couldnt think of > any way to do it. Then it is okay not to have it. Anyway you might try to persuade upstream to make releases... > > debian/copyright: > > > > You write GPL2 or later, while setup.py says GPLV2. Anyway upstream > > should include more license information. > > That was my fault. I double checked with upstream who confirmed it was > just GPLv2. Fixed. debian/copyright should also point to full license text, /usr/share/common-licenses/GPL-2 in this case. > > Other: > > > > I think it would be better to install NEWS as changelog using > > dh_changelog. > > Is this really necessary? At the moment installing things like that > are controlled by cdbs, so using dh_installchangelogs would make > debian/rules much more confusing and more difficult to maintain (not > ideal). I guess that setting DEB_INSTALL_CHANGELOGS_ALL=NEWS would do the job, but I'm neither cdbs expert nor fan. > > Having debian directory in upstream and patching is not the best way to > > go. I think you should remove it from upstream and distribute it in > > Debian diff. > > > Sorry, that was me creating the orig.tar.gz incorrectly from the bzr > branch. Fixed in latest upload. Anyway when you create the tarball, you should provide at least debian/README.source describing how to recreate it and preferably also get-orig-source target in debian/rules, which would do it. Also I just noticed, that tests/blackbox is not installed, but tests/__init__.py is and it references to blackbox... -- Michal Čihař | http://cihar.com | http://blog.cihar.com
Attachment:
signature.asc
Description: PGP signature