Re: RFS: jigzo

["Daniel Moerner" <dmoerner@gmail.com>]

Hi, I am not a Debian developer, but I noticed a few things about your package:

On Fri, Oct 24, 2008 at 10:29 PM, Elías A. M. <ealmdz@gmail.com> wrote:
> Dear mentors,
>
> I am looking for a sponsor for my package "jigzo".
>

First, your package is not lintian clean:
W: jigzo source: patch-system-but-direct-changes-in-diff makeinclude.linux
I: jigzo: arch-dep-package-has-big-usr-share 4284kB 97%
I: jigzo: desktop-entry-contains-encoding-key
/usr/share/applications/jigzo.desktop:4 Encoding

Here is the diff problem (the rest are information points, which are
worth fixing but not critical):

--- jigzo-0.6.1.orig/makeinclude.linux
+++ jigzo-0.6.1/makeinclude.linux
@@ -5,6 +5,6 @@
 CC  = gcc
 STRIP = strip
 APP = jigzo
-ARCHLDFLAGS = -lpthread -lGL -lpthread -lpng -ljpeg -lSDL -lSDL_mixer
+ARCHLDFLAGS =  -lpthread -lGL -lpthread -lpng -ljpeg -lSDL -lSDL_mixer
 ARCHCXXFLAGS = -I/usr/include/SDL

Second, your debian/rules file could use some cleaning.  You have
configure in the .PHONY, but no configure target in the file.  You
also should remove the commented dh_* lines--they just add cruft to
the diff.

Third, although your package builds fine in a chroot, it does not
build with fglrx installed on my machine.  I'm not sure if this is a
problem:
dpkg-shlibdeps: warning: diversions involved - output may be incorrect
 diversion by fglrx-glx from: /usr/lib/libGL.so.1
dpkg-shlibdeps: warning: diversions involved - output may be incorrect
 diversion by fglrx-glx to: /usr/lib/fglrx/diversions/libGL.so.1
dpkg-shlibdeps: warning: diversions involved - output may be incorrect
 diversion by fglrx-glx from: /usr/lib/libGL.so.1.2
dpkg-shlibdeps: warning: diversions involved - output may be incorrect
 diversion by fglrx-glx to: /usr/lib/fglrx/diversions/libGL.so.1.2
dpkg-shlibdeps: failure: no dependency information found for
/usr/lib/libGL.so.1 (used by debian/jigzo/usr/games/jigzo).
dh_shlibdeps: command returned error code 512
make: *** [binary-arch] Error 1
dpkg-buildpackage: failure: fakeroot debian/rules binary gave error
exit status 2

Cheers,
-- 
Daniel Moerner <dmoerner@gmail.com>