[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: toshset (updated package, ITA)



Michal Čihař ha scritto:

> If I rebuilt package twice I get huge changes to configure in debdiff:
> 
> $ debdiff toshset_1.73-3.dsc orig/toshset_1.73-3.dsc | diffstat 
>  configure | 4543 ++++++++++---------------------------------------------------- 
> 1 file changed, 751 insertions(+), 3792 deletions(-)
> 
> I guess you should delete it in clean target?

Fixed


> 
> $ lintian -IE toshset_1.73-3_amd64.changes
> W: toshset source: patch-system-but-direct-changes-in-diff configure
> W: toshset: manpage-has-errors-from-man usr/share/man/man1/toshset.1.gz 27: warning: `hr' not defined

Fixed

> Following compiler warnings can be easily fixed by adding 
> missing includes:
> 
> toshsat1800-irdasetup.c:265: warning: incompatible implicit declaration of built-in function ‘memcpy’
> toshsat1800-irdasetup.c:641: warning: incompatible implicit declaration of built-in function ‘exit’
> toshsat1800-irdasetup.c:708: warning: incompatible implicit declaration of built-in function ‘exit’
> toshsat1800-irdasetup.c:739: warning: incompatible implicit declaration of built-in function ‘exit’


Fixed.


> Also do you plan to address #487154?
> 

Previous maintainer wrote that the possible fix for #487154 is a kernel patch
[0], and I agree. Real problem is that toshiba_acpi and toshiba modules are not
loaded correctly. We are close to release, so I will ask to include that patch
for lenny+1


Uploaded again on mentors.

[0] http://memebeam.org/free-software/toshiba_acpi/


Giuseppe

Attachment: signature.asc
Description: OpenPGP digital signature


Reply to: