Re: RFS: winff

[Paul Gevers <paul@climbing.nl>]

Dear mentors,

I know I should be patient and that Lenny recently has been frozen, but
this is my first package for Debian and I would appreciate some feedback
on how I have done after a month waiting. I therefore take the liberty
to send this mail with my request for comments (or of course sponsorship).

For completeness I have added the full description of the winff package
this time.

winff      - video and audio batch converter using ffmpeg
 WinFF is a graphical user interface for FFmpeg. It will convert
 almost any video file that FFmpeg will convert. WinFF does multiple
 files in multiple formats at one time. You can, for example, convert
 mpeg's, flv's, and mov's into avi's (or DVD/VCD format or MPEG or 3gp
 etc.) all at once.

 This package provides a variety of preset conversion settings for
 common formats and devices. These presets are intended to hit the
 "sweet spot" for each individual codec. They have been written with a
 tip of the balance to quality.

> * Package name    : winff
>   Version         : 0.42-1
>   Upstream Author : Matthew Weatherford <matt@biggmatt.com>
> * URL             : http://www.winff.org
> * License         : GLP-3
>   Section         : graphics
>
> It builds this binary package:
> winff      - video and audio batch converter using ffmpeg
>
> The package appears to be lintian clean.
>
> The upload would fix these bugs: 485481
>
> The package can be found on mentors.debian.net:
> - URL: http://mentors.debian.net/debian/pool/main/w/winff
> - Source repository: deb-src http://mentors.debian.net/debian unstable
> main contrib non-free
> - dget
> http://mentors.debian.net/debian/pool/main/w/winff/winff_0.42-1.dsc

With kind regards
Paul

Paul Gevers wrote:
> Dear mentors,
> 
> I found several issues myself (copyright of language files and winff
> icon) and a wrong link to the icon in the desktop file, so those are fixed.
> 
> I would appreciate comments on/upload of the package. Again available at
> mentors:
> http://mentors.debian.net/debian/pool/main/w/winff/winff_0.42-1.dsc
> 
> With kind regards,
> Paul
> 
> Paul Gevers wrote:
>> Thanks for the quick review.
>>
>>> - No need to build-depend on fpc-source or you have a strong reason
>>> doing so ?
>>
>> Removed: done.
>>
>>> - Need to depend on ffmpeg since AFAICS it is being called by winff
>>> runtime.
>>
>> Huh, I am pretty sure I see it. I moved it to the first dependent
>> instead of the last.
>>
>>> - Vcs-Browser: is not for upstream repo, but for yours, i.e. the VCS
>>> repo of your packaging, if any.
>>
>> Ack. Removed.
>>
>> I would be glad if it could be uploaded after the changes. The package
>> is again available on mentors:
>> - dget
>> http://mentors.debian.net/debian/pool/main/w/winff/winff_0.42-1.dsc
>>
>> Paul