[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: gimmix



OoO En cette  matinée ensoleillée du mardi 08  juillet 2008, vers 09:54,
Vincent Legout <vincent@legout.info> disait :

> * Package name    : gimmix
>   Version         : 0.4.3-1
>   Upstream Author : Priyank M. Gosalia
> * URL             : http://gimmix.berlios.de/
> * License         : GPL
>   Section         : sound

Hi Vincent!

Not all files are licensed under GPLv2+. For example ./src/eggtrayicon.c
is   LGPLv2+.   You  should   list   all   those   exceptions  in   your
debian/copyright.

debian/compat  says 5 while  debian/control says  debhelper (>=  6). You
should fix this.

The fact that Gimmix is a GTK  client is more important than the fact it
is  written in  C. You  could tell  this is  a GTK  client in  the short
description  and drop  the fact  that it  is written  in C  in  the long
description. The  long description  is a bit  short. Maybe you  can list
some features of Gimmix.  For example, how does it compare with Ario?

The  manual page  that  you wrote  is  very short.  You  should use  the
template provided by dh-make instead:
 /usr/share/debhelper/dh_make/debian/manpage.1.ex

Your  debian/rules seems  to use  files from  automake-1.10.  You should
depend on this package instead of  just automake, IMO. This will avoid a
FTBFS when automake will switch to a more recent version.

You should try to get your key signed by some people (preferably DD). If
you live near Paris, I can sign it.
-- 
BOFH excuse #384:
t's an ID-10-T error

Attachment: pgp6eGd76FwW9.pgp
Description: PGP signature


Reply to: