Re: RFS: sshfp - DNS SSHFP records generator
Hi Maximiliano,
Le mardi 24 juin 2008 à 14:56 -0300, Maximiliano Curia a écrit :
> Hola Julien Valroff!
>
> El 23/06/2008 a las 21:01 escribiste:
> > > I've made several changes to your package, listed bellow:
>
> > > - I used the pristine tar.gz, as I don't see any reason not to.
[...]
> > I remember having read Daniel Baumann's recommendations [0] when taking
> > the decision to remove the existing debian/ directory.
>
> There is no consensus. But if you modify the pristine source it's always a good
> idea to document the process in the debian/rules get-orig-source.
I have decided to keep the pristine tarball. I guess upstream developers
will accept quite easily to remove the existing debian directory from
their next release if the application is uploaded into the official
archive.
> > > - I created a patch that fixes some quirks in the Makefile (should be forward
> > > to upstream).
> > > - I created a patch that fixes some quirks in the manpage (should be forward to
> > > upstream).
> > great, have you already forwarded these patches?
>
> No, being your RFS I believe you should contact upstream and send the patches.
Done and accepted upstream - thanks for sending them.
> > > - I changed the debian/copyright file to include the same text as is presented in
> > > the source code.
> > Maybe this file could be switched to the machine parsable format, what
> > do you think?
>
> That would be great.
Done.
> > > - I added the Homepage: field.
> > Wasn't it already added? I have a version with this field, as well as
> > the Vcs-* fields - I might have forgotten to upload this new version to
> > mentors.
>
> > I think it would be useful to add these Vcs-* fields once they have
> > reached a definitive location.
Done as well. I have added my personal (publicly accessible) repository.
Should you need a write access, I can have a look to my configuration (I
am not sure I remember exactly how this repository is set up).
> Ok, do the proposed changes and I'll review it again.
The updated package has been uploaded to mentors.d.n:
http://mentors.debian.net/debian/pool/main/s/sshfp
The respective dsc file can be found at:
http://mentors.debian.net/debian/pool/main/s/sshfp/sshfp_1.1.3-1.dsc
> > Adding "XS-DM-Upload-Allowed: yes" would also be a good thing for me if
> > you don't object to this idea.
[...]
> I prefer to review the package before its uploaded, until they don't need my
> intervention. And then we can add the "XS-DM-Upload-Allowed: yes".
OK, I understand.
I look forward to receiving your comments on the small updates.
Cheers,
Julien
Reply to: