Hi, On Fri, Feb 22, 2008 at 11:46:27PM -0300, Joel Franco wrote: > A long description is really difficult because the 2 words say all :) no, they don't. Imagine you would be someone who is interested in cloning a system, but you never heard about tee or netcat. How could the maintainer of such a program as nettee is, have written the description for you to find it? BTW. have a look at the manpage. IMHO the description which is used their is a good starting point. > > - lacks a Homepage header to indicate the homepage. See [1] > done Please move it to the source package part of the package, for example after the maintainer line. > >- debian/copyright > > - Some copyright holders are missing in that file > Sorry. i did not understand. > It's the original copyright missing? i have include it. > my copyright too? Well, the debian/copyright needs to contain the copyright of each copyright holder, each file and every differing license. If I do a rgrep -i '(c)' in the package source directory I still find copyrights that are not mentioned in your copyright file. > > - Its a good idea to include a "On Debian systems the license text > > can be found.." notice to the license of the software, because the > > link in the "packaging is licensed as following"-text looks like > > it *is* for the packaging only on ordinary people IMHO. > I have included your text to precede the file location. No. What I meant is soemthing like this: License: <.. License Excerpt ..> On Debian Systems the complete text of the ... License can be found in .. The Debian packaging is ... > I'tried to do it, but i don't have sure that it's correct because it's > not clear which data must be in debian/watch. I have included the > original upstream version download url. See the manpage for uscan. The format of the watch files is well documented there. Well, there are still some comments (besides what I've already written): - debian/copyright: Wrap lines after 80 characters - debian/rules: - Your CFLAGS are not used. Needs some investigation. - Its nitpicking, but please remove the useless empty whitespaces at some line endings (e.g. line 33 and 38) - debian/changelog: Needs some work. Changelog entries are not as they should be. See [1] for some instructions. - debian/docs: includes beowulf.master which does not seem to be a document, but instead an example. See the manpage for dh_installexamples on how to install examples - debian/README.Debian is still in the package. Remember that I and Paul told you, that its content is not really what the README.Debian is for. - debian/watch: No thats wrong. See the uscan manpage. Best Regards, Patrick [1] http://www.debian.org/doc/developers-reference/ch-best-pkging-practices.en.html#s-bpp-debian-changelog
Attachment:
signature.asc
Description: Digital signature