Hi, On Wed, Dec 10, 2008 at 10:12:20AM +0100, Sandro Tosi wrote: > Hello Ryan, > > On Wed, Dec 10, 2008 at 09:18, Ryan Niebur <ryanryan52@gmail.com> wrote: > > Dear mentors, > > > > I am looking for a sponsor for the new version 0.2.0-5 > > of my package "nast". > > Here are my comments: > > - why are config.sub,guess changed in the diff.gz? If you replace they aren't... $ curl -s http://mentors.debian.net/debian/pool/main/n/nast/nast_0.2.0-5.diff.gz | gunzip - | diffstat README.source | 2 changelog | 51 ++++++++++++++++++++ compat | 1 control | 31 ++++++++++++ copyright | 37 ++++++++++++++ dirs | 1 docs | 2 patches/fix-buffer-overflows | 40 +++++++++++++++ patches/fix-manpage | 38 +++++++++++++++ patches/fix-on-some-laptops | 70 +++++++++++++++++++++++++++ patches/series | 3 + rules | 108 +++++++++++++++++++++++++++++++++++++++++++ watch | 2 13 files changed, 386 insertions(+) > them, please rm them in the clean target ( there is no need to save > them in debian/ dir: removeing a file present in the upstream tarball, > will avoid its changes to appear in the diff, but the file will still > be present when unpacking since it's in orig.tar.gz) oh, I didn't know that. fixed. > - 3.8.0 request the Homepage field in source stanza of debian/control okay, fixed. > - you can remove "see COPYING file for details." from > debian/copyright; it's always better to refer to GPL-2 local file for > GPLv2+ software fixed. > - please forward the patches upstream (if you haven't done so yet) will do. > - the list of featurs has too much space at the beginning of the line: > please only use 2 spaces (so that packages.d.o will show the list in > verbatim) okay, fixed. > - clarify the license of debian packaging fixed. > - debian/dirs is probably not needed, look if you can remove cannot be fixed, upstream's Makefile is silly. > - can't you use dh_installman to install manpage instead of do it "by hand"? does it make much of a difference? anyway, fixed. > - remove all the commented/not needed dh_* calls fixed. > - please include a description (eventually the author too) in the > patches, as even lintian signals: > W: nast source: quilt-patch-missing-description gah. forgot to upgrade lintian. anyway, fixed. > - manpage has still many warnings: > I: nast: hyphen-used-as-minus-sign > okay, fixed. > Once fixed, please reupload (same debian revision) and reply to this email > reuploaded. > Regards, > -- > Sandro Tosi (aka morph, Morpheus, matrixhasu) > My website: http://matrixhasu.altervista.org/ > Me at Debian: http://wiki.debian.org/SandroTosi Thanks, Ryan -- _________________________ Ryan Niebur ryanryan52@gmail.com
Attachment:
signature.asc
Description: Digital signature