[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: whohas



On Tue, Dec 9, 2008 at 7:02 AM, Jonathan Wiltshire
<debian@jwiltshire.org.uk> wrote:

> http://mentors.debian.net/debian/pool/main/w/whohas/whohas_0.21-1.dsc
> Even if you are unable to sponsor I would appreciate a review.

Here is a review:

Why do you have Vcs-Browser, but not Vcs-Git?

${shlibs:Depends} isn't needed because whohas is a perl script.

Don't forget to send the manual page upstream if you haven't already.

For the manual page you might want to point users at
intro.html/intro.txt in a "SEE ALSO" section.

The "FILES" section in the manual page should talk about ~/.whohas
rather than the script filename.

Will upload once these issues are fixed.

Thanks for packaging whohas BTW, it looks like a quite useful tool for
upstream authors.

-- 
bye,
pabs

http://wiki.debian.org/PaulWise


Reply to: