Re: RFS: aoeui (updated package)
Hello,
On Tue, Nov 18, 2008 at 01:43, Daniel Moerner <dmoerner@gmail.com> wrote:
> On Mon, Nov 17, 2008 at 4:27 PM, Ryan Kavanagh <ryanakca@kubuntu.org> wrote:
>> Dear mentors,
>>
>> I am looking for a sponsor for the new version 1.2
>> of my package "aoeui".
>
> Hi, I am not a Debian Developer, so I can't sponsor you, but I did
> notice something:
>
> Upstream install target in the Makefile installs the *.txt files into
> /usr/share, but you install them again, gzipped, into /usr/share/doc.
> Is this duplication intentional?
>
> dmr@kronos:~/Work/mentor$ dpkg -c aoeui_1.2_i386.deb | grep txt
> -rw-r--r-- root/root 11237 2008-11-17 16:40 ./usr/share/aoeui/aoeui.txt
> -rw-r--r-- root/root 4790 2008-11-17 16:40 ./usr/share/aoeui/notes.txt
> -rw-r--r-- root/root 4773 2008-10-04 11:16
> ./usr/share/doc/aoeui/aoeui.txt.gz
> -rw-r--r-- root/root 2569 2008-10-04 11:16
> ./usr/share/doc/aoeui/notes.txt.gz
In addition to what Daniel said (of course, only files on
/usr/share/doc/<pkg> have to stay), here are other stuff to fix:
debian/changelog:
- why the package is native? use <upstream version>-<debian revision>
schema for debian versioning
- spell check the last entry (at least 'releas' is to be fixed)
debian/control
- the long description can be improved, in particular because policy
states not to repeat short description in the long one (what's almost
done here).
- the homepage is still on sourceforge?
debian/copyright:
- please clarify that the tool is under GPLv2 (in the reference to
local filesystem file) and that your work is under GPLv2 (stating it
explicitly)
- I'd rather (for aestetical reason) to have upstream author,
copyright and license notices all indented with 4 spaces
- I think it's better if you add a section ad-hoc for file
differencing from main copyright/license, at the bottom of the file
like: "The following files have different copyright notices" moving
there the "ebuild" copyright notice
- please prod the upstream author to add a clear copyright and licence
notices in every source file
debian/docs:
- why not install ./aoeui.html?
debian/patches/:
- no patch has documentation (see dpatch template), and changelog has
no reference to 02 patch
- did you forwarded upstream (if needed)?
debian/rules:
- what about install LOG (upstream changelog)
- Since you claim compatibility with policy 3.8.0, and you're using a
patch system, you need to include a debian/README.source to explain
how the build system works.
Please get back to me once you prepared an updated package.
Regards,
--
Sandro Tosi (aka morph, Morpheus, matrixhasu)
My website: http://matrixhasu.altervista.org/
Me at Debian: http://wiki.debian.org/SandroTosi
Reply to: