Re: RFS: cppcheck (2nd attempt)
Robert Wohlrab wrote:
On Tuesday 04 November 2008 23:56:11 Reijo Tomperi wrote:
Dear mentors,
I am looking for a sponsor for my package "cppcheck".
* Package name : cppcheck
Version : 1.25-1
Upstream Authors: Daniel Marjamäki <hyd_danmar@users.sourceforge.net>
Reijo Tomperi <aggro80@users.sourceforge.net>
* URL : http://cppcheck.wiki.sourceforge.net/
* License : GPL 3
Section : devel
It builds these binary packages:
cppcheck - C/C++ code analyzer
The package appears to be lintian clean.
- docs has duplicated entry
Fixed
- watch file is missing (see uscan man page for sourceforge examples)
Added (I hope it is correct, at least uscan from program's folder did
not give any errors.
- http://wiki.debian.org/Proposals/CopyrightFormat could be used to better
specify the copyright of debian/*
Fixed (I hope)
- Daniels name has non-utf8 encoding in FileLister.cpp, FileLister.h and
testtokenize.cpp (upstream issue)
Fixed ( I will try to get this fixed on the upstream also)
- Homepage tag in control is empty
Fixed
- clean doesn't remove autogenerated cppcheck.1
Fixed
- Vcs-((Git|SVN|..)|Browser) is missing in control. If you use a vcs to manage
your debian package - please add these.
I'm not using, but I have submitted the man page to the upstream so it
can be found from there.
- copyright section in cppcheck.1 is missing because you use docbook2x-man.
You should try to use xsltproc as suggested in cppcheck.1.xml and depend on
xsltproc and docbook-xsl instead of docbook2x
Fixed
- the correct link to GPL-2 (for your manpage) on debian systems is
/usr/share/common-licenses/GPL-2 and not /usr/share/common-licenses/GPL which
links currently to GPL-3
The example in the wiki-page you provided to me use the same target for
GPL-2+ license as I did ( I also have version 2 or later there):
http://wiki.debian.org/Proposals/CopyrightFormat#head-f4f1796c2acee38a5362a3f7fa26860623f28a4b
Is there perhaps an error in the wiki? For now I left it like it was
mentioned in the wiki.
- *-stamp will be removed by dh_clean and must not be removed by your clean
target
Fixed
- Why do you have configure target but don't configure anything? (it is not a
standard build target - see debian policy 3.8.0.1 section 4.9)
It was there because it was automatically generated by the tools I used
to create it. I removed it now.
- Why do you call dh_installexamples but don't install any example
Fixed
Can you add more informations about the program to the description? Maybe a
shortened list of features from the wiki.
I assume you mean the control file? If so, fixed.
I hope I did the right thing when I changed the version number from
1.25-1 to 1-25-2. I couldn't find much information about what to do
after getting first feedback.
Thank you for your quick response and feedback.
The updated package can be found on mentors.debian.net:
- URL: http://mentors.debian.net/debian/pool/main/c/cppcheck
- Source repository: deb-src http://mentors.debian.net/debian unstable
main contrib non-free
- dget
http://mentors.debian.net/debian/pool/main/c/cppcheck/cppcheck_1.25-2.dsc
- Reijo
Reply to: