Re: RFS: wmnetselect (updated package, QA upload, RC bugfix)
Hi Frank,
thanks for the review!
On Mon, Jul 28, 2008 at 03:47, Frank Lichtenheld <djpig@debian.org> wrote:
> On Sun, Jul 27, 2008 at 10:21:28PM +0200, Sandro Tosi wrote:
>> It builds these binary packages:
>> wmnetselect - enhanced Iceweasel launch button designed for WindowMaker
>>
>> The package appears to be lintian clean.
>>
>> I'm not really happy about direct upstream code modification, but
>> didn't want to introduce a patch system so I've just modified the
>> manpage to replace Netscape/Mozilla with Iceweasel/Iceape.
>>
>> The upload would fix these bugs: 419932
>
> I think you will need some code fixes, too...
>
> e.g.
> $ rgrep mozilla . | head -n 3
> ./wmnetselect.c:/* default executable is mozilla, may be overridden by command line parameter */
> ./wmnetselect.c:#define EXECUTABLE "mozilla"
> ./wmnetselect.c: " Defaults to mozilla",
Well, I've checked and mozilla is managed via alternatives to be iceweasel:
$ ls -l $(which mozilla)
lrwxrwxrwx 1 root root 25 2007-11-06 00:02 /usr/bin/mozilla ->
/etc/alternatives/mozilla
$ ls -l /etc/alternatives/mozilla
lrwxrwxrwx 1 root root 18 2008-07-19 13:19 /etc/alternatives/mozilla
-> /usr/bin/iceweasel
So it's working: or is it only on my system?
> Also you will need to verify that this does actually something useful
> afterwards.
Sure, I verified this too: if you double left-click the app, it open a
new tab in iceweasel, if you right-click it will open a tab for
google.com and if you paste with middle-click that text is passed to
iceweasel to be opened as URL.
> I actually skipped this package because I thought this wasn't worth the
> effort.
Of course it's not a critical package, but it didn't take too long to do it.
Thanks,
Sandro
--
Sandro Tosi (aka morph, Morpheus, matrixhasu)
My website: http://matrixhasu.altervista.org/
Me at Debian: http://wiki.debian.org/SandroTosi
Reply to: