[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: mpop - POP3 mail retriever (updated version)



Cyril Brulebois <kibi@debian.org> (06/07/2008):
> I'm going to have a look in a few hours unless someone beats me to it.

Some comments:
 - you may want to use the -S switch from debuild (or dpkg-buildpackage)
   and lintian-check your package, it contains config.log, which you
   could delete.
 - using lsdiff -z on the .diff.gz, one can notice that the manpage
   changes aren't reverted when building the source, it'd be nice to fix
   that.
 - you could delete the comments in debian/watch. Appropriate
   documentation can be found in uscan(1) in case someone forgets about
   the syntax and the common examples.
 - the boilerplate is (AFAIK) needed in debian/copyright, please don't
   remove it. Also, one has to specify the years for the copyright
   holders, but also: one has to use either “Copyright”, “Copr.” or “©”
   in front of the copyright year(s) and the author names, “(C)” doesn't
   mean anything (but can be added after “Copyright”, see usual FSF
   boilerplate).
 - debian/copyright doesn't say anything about debian/rules being public
   domain either.

I didn't test the runtime yet, will do once you've addressed the above
points.

Sorry for not having sent that before, I thought I would have more time
to check it more thoroughly, but I didn't yet. Will do in a second pass.

Mraw,
KiBi.

Attachment: signature.asc
Description: Digital signature


Reply to: