Re: RFS: freemat

["Bernhard R. Link" <brlink@debian.org>]

* Giuseppe Iuculano <giuseppe@iuculano.it> [080703 13:27]:
> I don't know if this is a good and elegant solution, but I run aclocal,automake,autoconf
> and I created a diff in debian/patches/ . In this way, make doesn't run again
> aclocal,automake,autoconf and debian/rules clean  seems to work now...

The disadvantages this solution has:

* the patches are more complicated than necessary (though they are overall small,
so this is not a big drawback in this case).

* it's relatively fragile w.r.t. timestamp issues. I guess it is
relatively safe here, as in your patches Makefile.am is always before
Makefile.in, so when applied the usual way, Makefile.in should never be
newer than Makefile.am (which would trigger automake to be rerun).

* you have to make sure everything is up to date and fits together.
It is relatively complicated to get right in that way.

For example in debian/patches/04_fix_path_dir.dpatch you have:

--- freemat-3.6~dfsg~/Makefile.in       2008-03-17 06:02:16.000000000 +0100
+++ freemat-3.6~dfsg/Makefile.in        2008-07-01 14:21:08.000000000 +0200
@@ -15,9 +15,9 @@
 @SET_MAKE@
 
 VPATH = @srcdir@
-pkgdatadir = $(datadir)/@PACKAGE@
-pkglibdir = $(libdir)/@PACKAGE@
-pkgincludedir = $(includedir)/@PACKAGE@
+pkgdatadir = $(datadir)/freemat
+pkglibdir = $(libdir)/freemat
+pkgincludedir = $(includedir)/freemat
 am__cd = CDPATH="$${ZSH_VERSION+.}$(PATH_SEPARATOR)" && cd
 install_sh_DATA = $(install_sh) -c -m 644
 install_sh_PROGRAM = $(install_sh) -c

but in debian/patches/99_fix_configure.dpatch you have:

diff -urNad freemat-3.6+dfsg~/Makefile.in freemat-3.6+dfsg/Makefile.in
--- freemat-3.6+dfsg~/Makefile.in       2008-07-03 12:15:53.000000000 +0200
+++ freemat-3.6+dfsg/Makefile.in        2008-07-03 12:23:45.000000000 +0200
@@ -1,8 +1,8 @@
-# Makefile.in generated by automake 1.10 from Makefile.am.
+# Makefile.in generated by automake 1.10.1 from Makefile.am.
 # @configure_input@
 
 # Copyright (C) 1994, 1995, 1996, 1997, 1998, 1999, 2000, 2001, 2002,
-# 2003, 2004, 2005, 2006  Free Software Foundation, Inc.
+# 2003, 2004, 2005, 2006, 2007, 2008  Free Software Foundation, Inc.
 # This Makefile.in is free software; the Free Software Foundation
 # gives unlimited permission to copy and/or distribute it,
 # with or without modifications, as long as this notice is preserved.
@@ -15,9 +15,9 @@
 @SET_MAKE@
 
 VPATH = @srcdir@
-pkgdatadir = $(datadir)/freemat
-pkglibdir = $(libdir)/freemat
-pkgincludedir = $(includedir)/freemat
+pkgdatadir = $(datadir)/@PACKAGE@
+pkglibdir = $(libdir)/@PACKAGE@
+pkgincludedir = $(includedir)/@PACKAGE@
 am__cd = CDPATH="$${ZSH_VERSION+.}$(PATH_SEPARATOR)" && cd
 install_sh_DATA = $(install_sh) -c -m 644
 install_sh_PROGRAM = $(install_sh) -c

i.e.: you first make a change, and then you revert it...

Hochachtungsvoll,
	Bernhard R. Link
-- 
"Never contain programs so few bugs, as when no debugging tools are available!"
	Niklaus Wirth