Re: RFS: irsim
Hi Vincent!
I have re-uploaded the package with the changes mentioned below.
Thanks a lot for the time you took to review the package.
Package link:
http://mentors.debian.net/debian/pool/main/i/irsim
On Sat, May 24, 2008 at 2:17 AM, Vincent Bernat <bernat@debian.org> wrote:
> Please, add an Homepage file to source stanza of debian/control. This
> gives a quick way to get upstream homepage without browsing through
> debian/copyright.
Done.
> Moreover, you state that you need debhelper 6 in debian/control but only
> debhelper 5 in debian/compat.
Done. Changed to 6 in debian/compat.
>
> Despite COPYRIGHT file at the root of the source code, this software
> seems not licensed under GPL... It would be better if upstream included
> a clearer statement about the global license that his software is
> licensed because some files do not contain any copyright statement (data
> files).
>
This is something the upstream will have trouble. Since they have
exclusively given a COPYRIGHT info on the root of the src folder, I am
not sure if they will be willing to add the header to all the src
files. I am not sure whether I have understood if this is what is
required either.
> Your 03_new_manpage_gentbl patch contains a bogus hunk (the first one).
Removed the bogus hunk.
>
> You can remove the fact that debian/rules is a sample file.
Done.
>
> You ship a lot of files in /usr/lib/irsim. Those files seem to be
> architecture independant and should be shipped in /usr/share/irsim
> instead. Moreover, you ship some documentation that should be moved into
> /usr/share/doc.
Moved all the files to the respective folders. Now the lintian
generates the following warning.
W: irsim: package-contains-empty-directory usr/lib/irsim/
Removing irsim folder generates the usr/lib folder empty message. Am
not sure how to do this. Pardon me for this stupid question.
Cheers!
Aanjhan
Reply to: