[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: snmpdump



OoO  Lors de  la soirée  naissante du  samedi 10  mai 2008,  vers 17:19,
Georgi Chulkov <g.chulkov@jacobs-university.de> disait:

> Dear mentors,
> I am looking for a sponsor for my package "snmpdump".

Hi Georgi!

I am commenting on this package and libanon too.

Please, file an ITP when working  on a package.  This avoid that someone
else works on it. After having filed an ITP, close it in your changelog.

Update  your package to  Standards-Version 3.7.3.  It should  require no
other change. Add the Homepage  field in debian/control. This will add a
link in PTS.  For libanon, add final point at the  end of sentences. You
should also leave a blank line before "This package contains...".

NEWS is empty, don't ship it. You can also drop README since it contains
no   data   of   interest.   Copyright   information   is   already   in
debian/copyright and build instruction are of no use for users of binary
packages.

Remove the fact that debian/rules is a sample. Also drop CFLAGS setting,
dpkg-buildpackage do it itself. Remove unused dh_* call (instead of just
commenting them out). Remove also  some comments whose goals are just to
help you to write debian/rules.  For libanon, remove version stuff since
your library is unversioned.

There is  a dependency  on OpenSSL.  Because  of license  restriction in
OpenSSL, upstream should add an exception allowing his code to be linked
with OpenSSL.   There is  also a missing  dependency on  pkg-config (the
OpenSSL check of configure fails without this one) for libanon. There is
a missing dependency on libpcap-dev for snmpdump.

The  clean  target  leaves   config.log.   libanon-dev  ships  an  empty
/usr/share/man/man1 directory.   Remove it  from dirs.  You  should also
patch manual page of snmpdump because hyphens are used as minus signs. I
get those information from lintian. Use it with "-viI" options.

Add a watch file too. This is pretty convenient to track if your package
is up-to-date.
-- 
panic("CPU too expensive - making holiday in the ANDES!");
	2.2.16 /usr/src/linux/arch/mips/kernel/traps.c

Attachment: pgpt7K_Ddx1JW.pgp
Description: PGP signature


Reply to: