Hi
On Tue, 6 May 2008 10:18:33 +0200
"Clement Lorteau" <northern_lights@users.sourceforge.net> wrote:
> Dear mentors,
>
> I am looking for a sponsor for my package "gtkvncviewer".
>
> * Package name : gtkvncviewer
> Version : 0.2.2-1
> Upstream Author : Clement Lorteau <northern_lights@users.sourceforge.net>
> * URL : https://launchpad.net/gtkvncviewer
> * License : GPLv2
> Section : utils
>
> It builds these binary packages:
> gtkvncviewer - Small GTK tool to connect to VNC servers.
>
> The package can be found on mentors.debian.net:
> - URL: http://mentors.debian.net/debian/pool/main/g/gtkvncviewer
> - Source repository: deb-src http://mentors.debian.net/debian unstable
> main contrib non-free
> - dget http://mentors.debian.net/debian/pool/main/g/gtkvncviewer/gtkvncviewer_0.2.2-1.dsc
>
> I would be glad if someone uploaded this package for me. I sent such a
> request last month and got a comment, which I acted upon, but it seems
> then the package got forgotten. That would be great if someone could
> have a new look at it.
Just a quick look:
- debian/changelog format looks strange
- debian/control
- Homepage is missing
- why do you depend on libgnome-keyring0?
- use pycentral or pysupport and ${python:Depends} instead of
depending on python2.5
- why does description start with empty line?
- try to describe package more than just one sentence
- debian/rules
- do not use mkdir, install, use dh_install instead
- no need for configure target if it is not used
- no need to set CFLAGS, you don't compile anything
- please remove commented out things
- package should be built by binary-indep as it is arch all
- you should not pass debian/changelog to dh_installchangelogs
- debian/dirs is IMHO not needed at all
- debian/copyright
- upstream tarball does not indicate that the
package is GPL, try contacting upstream to include license
information in package
- "This package was py2debianized(0.3-gtkvncviewer)"?
- please use lintian:
$ lintian gtkvncviewer_0.2.2-1_i386.changes
W: gtkvncviewer source: binary-arch-rules-but-pkg-is-arch-indep
W: gtkvncviewer: binary-without-manpage usr/bin/gtkvncviewer
I: gtkvncviewer:
desktop-entry-contains-encoding-key /usr/share/applications/data/gtkvncviewer.desktop:2
Encoding
W: gtkvncviewer: description-synopsis-might-not-be-phrased-properly
W: gtkvncviewer: spelling-error-in-description GTK GTK+
W: gtkvncviewer: spelling-error-in-description GTK GTK+
W: gtkvncviewer: new-package-should-close-itp-bug
--
Michal Čihař | http://cihar.com | http://blog.cihar.com
Attachment:
signature.asc
Description: PGP signature