[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: magic



OoO En  ce début d'après-midi ensoleillé  du samedi 26  avril 2008, vers
15:22, Aanjhan <aanjhan@tuxmaniac.com> disait:

> The package can be found on mentors.debian.net:
> - URL: http://mentors.debian.net/debian/pool/main/m/magic
> - Source repository: deb-src http://mentors.debian.net/debian unstable
> main contrib non-free
> - dget
> http://mentors.debian.net/debian/pool/main/m/magic/magic_7.5.129-1.dsc

> I would be glad if someone uploaded this package for me.

Hi Aanjhan!

You forgot to complete  debian/copyright, this is very important. Notice
that  it embeds a  copy of  readline while  other files  seem to  be BSD
licensed. This is a problem that should be addressed by upstream. Asking
him for a proper license notice would help too.

Random remarks:
 - there  is   a  mismatch  between   debian/compat  and  debian/control
   (debhelper 5/6).
 - you may add an Homepage field to debian/control
 - since you are using debian/dirs, don't use mkdir in debian/rules

Thanks.
-- 
printk(KERN_WARNING "Multi-volume CD somehow got mounted.\n");
	2.2.16 /usr/src/linux/fs/isofs/inode.c

Attachment: pgpV7ZywpVPwH.pgp
Description: PGP signature


Reply to: