[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: ext3grep



admins@acm.jhu.edu scrisse:

This is a quick review of your package, which need improvements before
being uploadable.

> The package appears to be lintian clean.

My lintian doesn't agree:

$ lintian -I ext3grep*d??
W: ext3grep-dbg: description-synopsis-might-not-be-phrased-properly 
E: ext3grep-dbg: description-synopsis-is-duplicated 
W: ext3grep-dbg: dbg-package-missing-depends ext3grep 
I: ext3grep: hyphen-used-as-minus-sign /usr/share/man/man8/ext3grep.8.gz

Your debian/copyright is wrong; there are files under GPLv3+
(eg. backtrace.cc) and other with different authors (eg. kernel-jbd.h).
Please inspect them all and assign proper owner/license to each one.
While you're at it, you could also consider
http://wiki.debian.org/Proposals/CopyrightFormat

Moreover, I won't really provide a separated -dbg package for a single
binary. Just build with debug symbol and dh_strip them later.
Optimization can be disabled as well while checking for "noopt".

A watch file and an Homepage: tags are strongly encouraged these; as
your package is hosted as googlecode, and could be easily added, please
do so.

This a first roughly review... I will be glad to check it deeply when
an improved package will be available.

> Kind regards
>   Rich Ercolani

Ciao, Luca

-- 
 .''`.  ** Debian GNU/Linux **  | Luca Bruno
: :'  :   The Universal O.S.    | lucab (AT) debian.org
`. `'`  			| GPG Key ID: 3BFB9FB3
  `-     http://www.debian.org 	| Debian GNU/Linux Developer

Attachment: pgpU1b3DBHMxF.pgp
Description: PGP signature


Reply to: