Re: RFS: compiz-switch
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Helmut Grohne ha scritto:
>> * Package name : compiz-switch
>
> 1) Your diff.gz modifies files out side debian/. Many sponsors will
> consider this a bad practise, so I suggest using a patch system like
> dpatch or quilt in order to reach more potential sponsors.
I know, but I'm modifying only one line in the makefile, to fix
installation path: IMHO it doesn't makes the diff difficult to read;
using a patch (and thus adding it as build-dep) seems to me a little
oversized... Am I saying nonsense?
>
> 2) There is a debian/menu file. However dh_installmenu is not called.
> Why?
Simply forgot it... :) Fixed. But a question arises: I'm using the
section Screen directly, because a section as Applications/Tools doesn't
exists. There is a better choice?
>
> 3) Your diff.gz looks like it is not properly cleaned as it ships a
> manpage in two formats.
Cleaned up.
Thank you.
- --
Alessio Gaeta
http://meden.uni.cc
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFH+QJnirbk3DO+UZ0RAm9HAJ9b8/dj2rwKVY7G9Y3dbyMxHD7YvwCgluYI
QQjpssIAOcbORi4XoWTV86c=
=9ScO
-----END PGP SIGNATURE-----
Reply to: