Re: RFS: mxml (updated package)
On Jul 20, 2007 4:55 PM, Luis Uribe <acme@eviled.org> wrote:
> I am looking for a sponsor for the new version 2.3-1
> of my package "mxml".
Is the version 2.4-1 on mentors ready to be uploaded?
If so, I think it should be uploaded since overall it improves apon
the package already in Debian.
That said, some problems you may want to fix:
A review of the 2.4-1 interdiff:
Homepage is a real field now: http://wiki.debian.org/HomepageFieldHOWTO
442416 is not "please package a new release" therefore put it on a
line with "Fix loading zynaddsubfx's XML files".
You seem to have added test/.cvsignore, doc/.cvsignore, .cvsignore, why?
About the rpath removal patch, maybe it would be better to use chrpath
mentioned at http://wiki.debian.org/RpathIssue than patching
A review of the whole 2.4-1 package:
Perhaps you could ask upstream to fix the rpath issue in the next release?
Might want to add this to your quilt config and refresh the patches:
QUILT_REFRESH_ARGS="-p0 --no-timestamps --no-index"
Some other useful quilt bits:
QUILT_PATCH_OPTS="--unified-reject-files"
QUILT_DIFF_ARGS="--color=auto --no-timestamps --no-index"
QUILT_COLORS="diff_hdr=1;32:diff_add=1;34:diff_rem=1;31:diff_hunk=1;33:diff_ctx=35:diff_cctx=33"
The special thing for nostrip is not needed now, dh_strip handles it.
You don't install manpages using dh_installman, so don't run it.
Upstream seems to be using the -Os optimisation flag and then it gets
overridden by -O2 from debian/rules. Since this is a mini-xml parser,
maybe it would better to use -Os too, unless noopt is on?
Most humans will be looking for libmxml-dev, so I suggest moving most
of the libmxml1 description to the libmxml-dev description.
Some dpkg-shlibs warnings (hmmmmm hmmm hmmmm):
dpkg-shlibdeps: warning: debian/libmxml-dev/usr/bin/mxmldoc shouldn't
be linked with libpthread.so.0 (it uses none of its symbols).
dpkg-shlibdeps: warning: symbol pthread_once used by
debian/libmxml1/usr/lib/libmxml.so.1.4 found in none of the libraries.
dpkg-shlibdeps: warning: symbol pthread_setspecific used by
debian/libmxml1/usr/lib/libmxml.so.1.4 found in none of the libraries.
dpkg-shlibdeps: warning: symbol pthread_key_create used by
debian/libmxml1/usr/lib/libmxml.so.1.4 found in none of the libraries.
dpkg-shlibdeps: warning: symbol pthread_getspecific used by
debian/libmxml1/usr/lib/libmxml.so.1.4 found in none of the libraries.
May also want to check these:
http://wiki.debian.org/Projects/ImprovedDpkgShlibdeps
http://qa.debian.org/cgi-bin/mole/seedsymbols?pkgname=libmxml1
http://qa.debian.org/cgi-bin/mole/seedsymbols/.raw/seedsymbols/libmxml1_common
Lintian info messages:
I: libmxml1: description-contains-homepage
I: libmxml-dev: hyphen-used-as-minus-sign usr/share/man/man1/mxmldoc.1.gz:30
I: libmxml-dev: hyphen-used-as-minus-sign usr/share/man/man1/mxmldoc.1.gz:32
I: libmxml-dev: hyphen-used-as-minus-sign usr/share/man/man1/mxmldoc.1.gz:34
I: libmxml-dev: hyphen-used-as-minus-sign usr/share/man/man1/mxmldoc.1.gz:46
I: libmxml-dev: hyphen-used-as-minus-sign usr/share/man/man1/mxmldoc.1.gz:48
I: libmxml-dev: hyphen-used-as-minus-sign usr/share/man/man1/mxmldoc.1.gz:50
I: libmxml-dev: hyphen-used-as-minus-sign usr/share/man/man1/mxmldoc.1.gz:64
I: libmxml-dev: hyphen-used-as-minus-sign usr/share/man/man1/mxmldoc.1.gz:66
I: libmxml-dev: hyphen-used-as-minus-sign usr/share/man/man1/mxmldoc.1.gz:77
I: libmxml-dev: hyphen-used-as-minus-sign usr/share/man/man1/mxmldoc.1.gz:81
I: libmxml-dev: hyphen-used-as-minus-sign
usr/share/man/man1/mxmldoc.1.gz 3 more occurrences not shown
I: libmxml-dev: hyphen-used-as-minus-sign usr/share/man/man3/mxml.3.gz:327
I: libmxml-dev: description-contains-homepage
--
bye,
pabs
http://wiki.debian.org/PaulWise
Reply to: