[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: kopete-otr 0.7-1



Hi Paul,

On Friday 16 November 2007, Paul Wise wrote:
> On Nov 13, 2007 10:09 PM, Francesco Cecconi <francesco.cecconi@gmail.com> wrote:
> 
> > I am looking for a sponsor for my package "kopete-otr".
> 
> A review of your package:
> 
> Any reason you use automake1.9 instead of the default version of
> automake (1.10)?
fixed

> 
> extra blank lines at the end of debian/control debian/watch
fixed

> 
> hmm, I'm not sure about those lintian overrides, perhaps the library
> should be either made into a private library or split out into a
> separate package?
the package is very small, and the libraries not important for another package, 
for this reason the split IMHO isn't necessary. :)

> 
> no need to install AUTHORS, since debian/copyright covers it
fixed

> 
> There are a couple of "using uninitialised variable" and other
> warnings from gcc 4.2, please investigate them and send patches
> upstream.
I have checked the code but is a developer choise. :)

Many thanks, Paul :)
> 
> -- 
> bye,
> pabs
> 
> http://wiki.debian.org/PaulWise
> 
> 
Cheers,
Francesco
-- 
Francesco Cecconi ' |BrAnD| '
francesco.cecconi@gmail.com
GPG Key ID: 11F6E468 | Debian pkg Maintainer
Kde Italian team | www.kde-it.org
Nmapsi4 developer | nmapsi4.sourceforge.net

Attachment: signature.asc
Description: This is a digitally signed message part.


Reply to: