Bug#450608: debhelper: [DH_FIXPERMS] bin/* are updated with v5 too (Re: Executable's execute permission not getting set)

[Justin Pryzby <jpryzby+d@quoininc.com>]

Package: debhelper
Version: 5.0.42
Severity: minor
Tags: patch
File: /usr/bin/dh_fixperms
User: debhelper@packages.debian.org
Usertag: dh_fixperms
X-Debbugs-Cc: debian-mentors@lists.debian.org

On Thu, Nov 08, 2007 at 04:16:06PM +0100, Bernd Zeimetz wrote:
> Arnaud Fontaine wrote:
> >>>>>> "Bernd" == Bernd Zeimetz <bernd@bzed.de> writes:
> > 
> > Hello,
> > 
> >     Bernd>  if I understand  dh_fixperms manpage  correctly it  does not
> >     Bernd> 'fix'  the permissions for  bin directories anymore.   So you
> >     Bernd> just want to add a chmod 755 somewhere.
> > 
> > However, dh_fixperms seems to fix the permissions for bin directories if
> > compat  >= 4  according to  the  manpage ("It  makes all  files in  bin/
> > directories, /usr/games/  and etc/init.d executable (v4  only)")
> 
> v4 only sounds like compat ==4 imho. If not it should probably updated
> to since v4.
You're right:

| # v4 and up
| if (! compat(3)) {
|         # Programs in the bin and init.d dirs should be executable..
|         for my $dir (qw{usr/bin bin usr/sbin sbin usr/games etc/init.d}) {

--- /usr/bin/dh_fixperms
+++ /tmp/tmp.cCMEZ29704/dh_fixperms	2007-11-08 10:29:23.000000000 -0500
@@ -24,8 +24,8 @@
 the permissions of all man pages to mode 644. It makes all files be owned
 by root, and it removes group and other write permission from all files. It
 removes execute permissions from any libraries that have it set. It makes
-all files in bin/ directories, /usr/games/ and etc/init.d executable (v4
-only). Finally, it removes the setuid and setgid bits from all files in the
+all files in bin/ directories, /usr/games/ and etc/init.d executable (since
+v4). Finally, it removes the setuid and setgid bits from all files in the
 package.
 
 =head1 OPTIONS