[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: file encoding and eol marker in orig.tar.gz



On Thu, Nov 08, 2007 at 03:24:40PM +0100, Bas Wijnen wrote:
> I don't know much about java, but if those are just compilations of
> things for which the source is also in the tarball, there is no need to
> repackage.  You can remove them in the clean target in debian/rules, for
> example, to make sure they are regenerated.  But of course I may be
> completely missing the point. :-)

The idea is that FTP master rejects abt binary content in your
orig.tar.gz for which you don't have source. So, if you package for
Java, remove all the jars, package them from their source, and
repackage your original program (Build-)?Depending on the others.

> > 1) Should I convert eol markers (fromdos)? Or at least should I fix
> > the half a dozen files which have CRLF+CR as eol markers?
> 
> I wouldn't do that.  Repackaging is done to make the tarball complient
> with our standards, not to beautify it.  If this conversion is a good
> idea (and I agree that it is), then that is an upstream issue, and it
> should be fixed there.  Asking them about it is a good idea, changing it
> in the package is not IMO.

I had to do this, because this caused some build failed for some
reason (I don't recall, but my mentor asked me to do it). Also, my
patches looked too ugly.

Kumar
-- 
Kumar Appaiah,
458, Jamuna Hostel,
Indian Institute of Technology Madras,
Chennai - 600 036



Reply to: