Re: RFS: softbeep (updated package)
Hi,
> On Fri, Jan 26, 2007 at 02:18:56PM +0100, Thijs Kinkhorst wrote:
>> * There are open bugs in the bts for softbeep, which have no response
>> yet, and might have some merit. Have you looked at the bugs? Can they
>> be fixed in this upload? If not, you could respond to the reporters
>> why it will not (yet) be resolved.
> Ok, will look at it.
>> * You install the upstream file "RELEASES" as documentation, but it is
>> some sort of a changelog. I propose to have it installed by
>> dh_installchangelogs instead.
> Well, that's how the package was. Anyways, I just read the manpage of
> dh_installchangelogs, but I don't understand how to use it to specify
> RELEASES as a changelog.
Try this:
dh_installchangelogs RELEASES
>> * Your patches have very generic names: 01-shlibs.dpatch 02-sb.dpatch
>> 03-sb-beep.dpatch, and there's multiple unrelated changes per file.
>> I'd prefer if the filenames describe what the patch does, and that you
>> separate the patches per subject. This makes it easy to add, update or
>> remove a specific patch.
> Again that's how the package was, I only added 03-sb-beep.dpatch.
Ok, it's not a blocker for uploading, and mostly your preference. I do
think that mixing unrelated changes in one patch can be inconvenient. The
nice thing about a patching system is that you can easily add, edit and
disable a specific change.
Thijs
Reply to: