Re: RFS: jabbin
On 1/26/07, Bernhard R. Link <brlink@debian.org> wrote:
I've no audio on my unstable boxes, so I'm unable to test (and thus to
sponsor) the package, but some things I noticed:
* As is is a snapshot, telling which command was used to generate it would
be nice, so the non-svn savy of us can more easily verify that it is
genuine. (If it was downloaded from somewhere, please give the link to
that, as the link in the debian/copyright is no archive)
It's using a script stored in upstream's SVN repo
(https://jabbin.svn.sourceforge.net/svnroot/jabbin/trunk/) called
admin/debian.sh. If you want to see how the building is done then just
look there. It essentially strips out the .svn directories and the
administrivia stuff.
* if you generate the .tar yourself anyway, you could let out the
"3party" stuff. Otherwise it would be nice to note somewhere how
you have made sure that the Debian versions have been used instead
of statically using the shipped stuff. Or at least how the stuff
it includes is different from the Debian versions that using it
instead of the installed versions could possibly excused.
I'm going to have to look into this: upstream says modifications were
made at least to libjingle, in my first RFS in August someone tried
and said it didn't work. I'll have to investigate.
* As it contains so much stuff, I'm a bit lost what code is actually
used. But the resulting binaries might be indistributeable, as the
main program is GPL with exceptions for qt and stuff only accessed
via qt or qca, while it also seems to be used at other parts which
look like they might also be used more directly. (libjingle, xmlsec)
If nothing bad happens, some note in the source package that nothing
bad happens and why would be nice.
Sorry, I don't understand what you're saying here.
--
Andrew Donnellan
ajdlinuxATgmailDOTcom (primary) ajdlinuxATexemailDOTcomDOTau (secure)
http://andrewdonnellan.com http://ajdlinux.wordpress.com
ajdlinux@jabber.org.au hkp://subkeys.pgp.net 0x5D4C0C58
http://linux.org.au http://debian.org
Get free rewards - http://ezyrewards.com/?id=23484
Reply to: