Re: RFS: poco

[Daniel Baumann <daniel@debian.org>]

Krzysztof Burghardt wrote:
> http://mentors.debian.net/debian/pool/main/p/poco/poco_1.2.8-1.dsc

  * remove the useless empty line at the end of changelog.

  * can you reword the long description to something more easy and
    shorter?

  * docs is a non prefixed helper, please prefix it with the package
    name you want to assign it.

    if you don't have a package prefix when building a multi binary
    package, it is automatically assigned to the first binary package
    listed in control.

  * if you install the files with .install helpers, you don't need
    to create the directory with dirs for those.

  * remove *postinst, *postrm, they are automatically added by debhelper
    anyway.

  * remove the useless commented stuff in rules.

  * this is not needed in your rules:

---snipp---
# shared library versions, option 1
version=2.0.5
major=2
# option 2, assuming the library is created as src/.libs/libfoo.so.2.0.5
or so
#version=`ls src/.libs/lib*.so.* | \
# awk '{if (match($$0,/[0-9]+\.[0-9]+\.[0-9]+$$/)) print
substr($$0,RSTART)}'`
#major=`ls src/.libs/lib*.so.* | \
# awk '{if (match($$0,/\.so\.[0-9]+$$/)) print substr($$0,RSTART+4)}'`
---snapp---

  * do not have DH_VERBOSE on by default

  * do not use more than one empty line as seperator, one is just
    enough.

  * you should remove dh_installman, you don't need that,
    and uncomment dh_makeshlibs, you need that.

  * the package does not build:

---snip---
make[2]: Leaving directory `/home/user/poco-1.2.8.orig/XML'
make[2]: Entering directory `/home/user/poco-1.2.8.orig/XML'
mkdir -p /home/user/poco-1.2.8.orig/XML/obj/Linux/i686/release_static
mkdir -p /home/user/poco-1.2.8.orig/XML/obj/Linux/i686/debug_static
mkdir -p /home/user/poco-1.2.8.orig/XML/obj/Linux/i686/release_shared
mkdir -p /home/user/poco-1.2.8.orig/XML/obj/Linux/i686/debug_shared
make[2]: *** No rule to make target `/home/user/poco-1.2.8.o', needed by
`/home/user/poco-1.2.8.orig/XML/obj/Linux/i686/debug_shared/AbstractContainerNode.o'.
 Stop.
make[2]: Leaving directory `/home/user/poco-1.2.8.orig/XML'
make[1]: *** [XML-libexec] Error 2
make[1]: Leaving directory `/home/user/poco-1.2.8.orig'
make: *** [build-stamp] Error 2
(unstable_i386)user@debian:~/poco-1.2.8.orig$
---snap---

if you fixed above things, i'll check again.

-- 
Address:        Daniel Baumann, Burgunderstrasse 3, CH-4562 Biberist
Email:          daniel.baumann@panthera-systems.net
Internet:       http://people.panthera-systems.net/~daniel-baumann/