On Mon, Dec 17, 2007 at 02:02:06PM -0600, Luis Rodrigo Gallardo Cruz wrote:
> On Mon, Dec 17, 2007 at 06:44:23PM +0200, Peter Pentchev wrote:
> > Dear mentors,
> >
> > I am looking for a sponsor for the new version 0.2.1-3 of the "wmanager"
> > package; I am hereby attempting to adopt it, fix its two bugs, and bring it
> > up-to-date with the Debian policy and the modern world in general :)
>
> I will review your package. You made quite a few changes, so it might
> take me several days.
Ok, my (very few) comments:
1. You have in debian/rules
build: patch build-stamp
build-stamp: debian/control $(MAN)
and
clean: clean-patched unpatch
clean-patched: debian/control
That's bad, because those rules might fail if the package is ever
built with -j, since they don't enforce patching before building and
cleaning before unpatching.
Please change them to something like
build: patch-stamp build-stamp
build-stamp: debian/control patch-stamp $(MAN)
and
clean: debian/control
[commands ...]
$(MAKE) -f debian/rules unpatch
2. It would be nice to pass along at least the makefile patch
upstream. Now, upstream does not seem to be very active. Is that
because of lack of bugs, or a lack of upstream? If the second case is
true, you will be having to act as _de facto_ upstream. Are you
willing and able to do this? I'm not raising an objection here, I just
want you to state it explicitely.
3. Will you be wanting to keep debian/rules as is, or are you planning
to migrate to some helper package? If the second, be aware that I'm
not willing to sponsor cdbs based packages. I don't understand it and
I'm not really willing to learn it. Thus, I'd politely recommend ;)
you use debhelper.
Other than that, your package is very nicely updated, so as soon as
you do the patching rules fixes, I can sponsor this version.
--
Rodrigo Gallardo
GPG-Fingerprint: 7C81 E60C 442E 8FBC D975 2F49 0199 8318 ADC9 BC28
Attachment:
signature.asc
Description: Digital signature