Ryan Schultz wrote: > * License : GPL <snip> > DFSG repackaging removes a plugin with ambiguous licensing. It seems there's still an awful lot of files without explicit licenses[0]. Can you get upstream to take a look and perhaps rectify this? Also, the whole upstream build-system seems completely misused. I didn't go very deep into the package (the build system scared me :-) ), but here are some remarks: - You could bump to debhelper >= 5 (both build-deps and compat file) - Even though the build-system is a mess, perhaps patching the config.h instead of copying over it would be better? - The whole arch-dependent logic for passing arguments to MAKE could be avoided, specially since they're practically the same for all arches. Use the schemes provided in the reference and policy to handle '-O2 -Wall -g'. Probably just adding '-DX86' in case of i386 and '-DCOMPARE_CORE -D_BIG_ENDIAN' in all other cases could be better then setting the whole option line in one go. (anyway, are these options really necessary?) - Changelog.DFSG shouldn't be in the source root, instead it should be moved to somewhere like debian/README.debian or debian/README.Debian-source. - The DFSG tarball should only have the offending files removed, the other changes mentioned in Changelog.DFSG should be handled via patching on build-time (via dpatch, quilt, etc). Hope it helps. Cheers [0] since many files have a non-standard copyright header, I found them via a dirty 'licensecheck -r ./ | grep UNKNOWN | cut -d: -f1 | while read file; do grep -L "General Public Licence" $file; done' -- Leo "costela" Antunes [insert a witty retort here]
Attachment:
signature.asc
Description: OpenPGP digital signature