Hi, thanks for the review. :) Il giorno mar, 09/10/2007 alle 18.03 +1000, Paul Wise ha scritto: > On 10/9/07, Francesco Namuri <francesco@namuri.it> wrote: > > http://mentors.debian.net/debian/pool/main/d/dictconv/dictconv_0.2-1.dsc > > diff review: > > uneeded blank lines in debian/watch, debian/rules Fixed > Homepage in description is obsolete, please move to the new dpkg field > (in the source package stanza) Nice, Fixed > Uses obsolete section in the menu entry. Might want to add an icon, > title and longtitle to the menu entry. Added longtitle and fixed capitalization of title. Apropos the icon: I haven't put any because it's console/text program that makes nothing called by the menu without any argument... Maybe it's useless to add a menu file? mmmm > No need to put the full title of the ITP bug in debian/changelog Fixed this one also, so it's useless to use dch --closes? Cheers, francesco The respective dsc file can be found at: http://mentors.debian.net/debian/pool/main/d/dictconv/dictconv_0.2-2.dsc -- Francesco Namuri francesco(at)namuri(dot)it http://namuri.it/ id gpg key: 21A4702A accipiter@jabber.org
Attachment:
signature.asc
Description: Questa =?ISO-8859-1?Q?=E8?= una parte del messaggio firmata digitalmente