[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: pingus (updated package)


Here's a list of things I found in the package:

- The second '*' in debian/changelog is indented incorrectly.

- About XS-DM-Upload-Allowed: I almost don't dare to say it, but I'd
  like to have it added again. ;-)  Perhaps it's better to wait until
  Miriam is back from her break, and leave it as it is for now. :-)

- in debian/rules, there is (in the clean target) "-scons -c".  This
  looks like "-$(MAKE) clean", for which there is a lintian warning.
  What can go wrong with cleaning?  It is unlikely you want to ignore
  all possible errors.  Some construct similar to
  "test ! -e Makefile || $(MAKE) clean" might be appropriate here as
  well (testing for the specific thing you want to ignore, and normally
  abort on any other error).

- in debian/rules, in the binary-arch target there is a commented-out
  line with dh_makeshlibs.  This is fine if you expect the package to
  make shared libraries in the (near) future, but I don't think that is
  the case?  If it will not be used, it's just confusing and should be

- You are breaking the Build-Depends line (which is fine), but it still
  doesn't fit on an 80 column display.

- The homepage is probably better mentioned such that it can be found by
  parsers.  The "old" way is to have "  Homepage: http://..."; in the
  long description(s).  The "new" way (which isn't supported by
  everything yet) is to use "Homepage: http://..."; in the first
  paragraph of debian/control.  For now, it is probably best to do both.
  Note that the new way triggers a lintian warning about an unknown
  field, but you can ignore that (and IMO you don't need an override;
  this is something that should be fixed in lintian, overrides are for
  unusual situations that give false positives, but are so rare that
  lintian doesn't need to be changed to avoid them).

- There is a lintian override installed, which isn't documented in the
  changelog.  Why is it needed?  (In other words, what rare situation do
  you have here, which warrants an override instead of a lintian bug?)

- During build, it reports: "* XInput support: disabled".  Is that
  intentional?  Do we miss input devices such as game pads because of

- Upstream switched on the "official build" flag.  You don't switch it
  off.  I expect that to be correct, but want to be sure you know.

A pretty long list, but none of them are big problems. :-)


On Mon, Sep 24, 2007 at 12:39:33AM +0100, Marco Rodrigues wrote:
> Dear mentors,
> I am looking for a sponsor for the new version 0.7.1-1
> of my package "pingus".
> It builds these binary packages:
> pingus     - Free Lemmings(TM) clone
> pingus-data - Data files for pingus, a free Lemmings(TM) clone
> The package appears to be lintian clean.
> The package can be found on mentors.debian.net:
> - URL: http://mentors.debian.net/debian/pool/main/p/pingus
> - Source repository: deb-src http://mentors.debian.net/debian unstable main
> contrib non-free
> - dget http://mentors.debian.net/debian/pool/main/p/pingus/pingus_0.7.1-1.dsc
> I would be glad if someone uploaded this package for me.
> -- 
> Marco Rodrigues
> http://Marco.Tondela.org
> -- 
> To UNSUBSCRIBE, email to debian-mentors-REQUEST@lists.debian.org
> with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org

I encourage people to send encrypted e-mail (see http://www.gnupg.org).
If you have problems reading my e-mail, use a better reader.
Please send the central message of e-mails as plain text
   in the message body, not as HTML and definitely not as MS Word.
Please do not use the MS Word format for attachments either.
For more information, see http://pcbcn10.phys.rug.nl/e-mail.html

Attachment: signature.asc
Description: Digital signature

Reply to: