Re: RFS: php-mdb2 (2nd attempt)

[Gregory Colpart <reg@evolix.fr>]

Hello,

On Fri, Sep 14, 2007 at 03:32:06PM -0400, Mark A. Hershberger wrote:
> 
> I am looking for a sponsor for my package "php-mdb2".

debian/changelog:
* it may be fun to have the date when you finish your package,
  use 'dch -r' before uploading for example ;-)

debian/control:
* set a versionned depend on php-pear: php-pear (>= 5.2.0-8)
* begin short description to "PHP PEAR module for ..."
* add Homepage field

debian/copyright:
* you copyright file is incomplete:
  - verify copyright in all upstream files, you don't mention all
    authors.
  - include the exact license text or mention the right
    file in /usr/share/common-licenses/ (but this license looks
    like a BSD licence *style*, then include it)
  - there is a strange condition in license text:
---8<---
// | Neither the name of Manuel Lemos, Tomas V.V.Cox, Stig. S. Bakken,    |
// | Lukas Smith nor the names of his contributors may be used to endorse |
// | or promote products derived from this software without specific prior|
// | written permission.                                                  |
---8<---
    Verify with debian-legal if this is okay for Debian main.

debian/README.Debian
* if you don't have interesting stuff to add, remove it

debian/postinst and debian/prerm:
* you don't need this file because register/unregister is dealt
  with pear.mk cdbs class. BTW there ware some discussions about
  the way to install/remove modules and final choice is given in
  dh-make-php package : directly in debian/rules and not in
  postinst/prerm files


Regards,
-- 
Gregory Colpart <reg@evolix.fr>  GnuPG:1024D/C1027A0E
Evolix - Informatique et Logiciels Libres http://www.evolix.fr/