Re: RFS: mirmon

[Patrick Schoenfeld <schoenfeld@in-medias-res.com>]

Hi,

Hideki Yamane wrote
> [...]
> The package can be found on mentors.debian.net:

IANADD but anyways some (hopefully useful) comments.

- debian/rules:
  * There is no reason to keep all those comments, that come from
    the template you are using for it
  * Is there any reason to recreate the (already existing) manpage
    during build? Eventually the other way round: Is it needed to have
    a manpage in debian/ if you create a newer version of it during
    build? Also this causes the clean target to be (afaic) not
    policy-confirm, cause it leaves changes to the source unreverted.
  * i would also remove the un-needed empty lines (like the ones between
    #export DH.. and CLFAGS)
  * you have a lot of uncommented debhelpers in your rules file. there
    is no reason to keep them in the file.
  * is there a reason why you create the patch/unpatch targets yourself?
    you could use dpatch.make (see dpatch.make(7))
- debian/copyright:
  Seems like you copied the license text from a source file due to the
  comment signs. should be removed, imho.
- debian/watch
  Is there a reason for the empty lines at the end of the file?

General comments:
The programs default location contains a state definition, which points
to a place inside the document root. would that normally be wanted?

Regards,
Patrick