[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: cellwriter



On 9/6/07, Michael Levin <risujin@risujin.org> wrote:

> http://mentors.debian.net/debian/pool/main/c/cellwriter/cellwriter_1.0.0.dsc
> Could someone upload my package please?

Firstly, please make a non-native package (diff.gz and orig.tar.gz
instead of just a tar.gz).

Please file an intent to package bug and close it in the changelog:

http://www.debian.org/devel/wnpp/#l1

Your package fails to build in a clean chroot (I tried in cowbuilder):

cc -DDATADIR=\"/usr/share\" -DPKGDATADIR=\"/usr/share/cellwriter\" -g
-Wall -O2   -o cellwriter main.o window.o unix.o cellwidget.o
recognize.o stroke.o options.o averages.o wordfreq.o preprocess.o
-lgtk-x11-2.0 -lgdk-x11-2.0 -latk-1.0 -lgdk_pixbuf-2.0 -lm
-lpangocairo-1.0 -lfontconfig -lXext -lXrender -lXinerama -lXi
-lXrandr -lXcursor -lXfixes -lpango-1.0 -lcairo -lX11 -lgobject-2.0
-lgmodule-2.0 -ldl -lglib-2.0   -Wl,--export-dynamic -pthread
-lgnome-2 -lpopt -lbonobo-2 -lbonobo-activation -lgmodule-2.0 -ldl
-lORBit-2 -lgthread-2.0 -lrt -lgobject-2.0 -lglib-2.0   -lm
unix.o: In function `key_event_send_bksp':
/tmp/buildd/cellwriter-1.0.0/src/unix.c:250: undefined reference to
`XTestFakeKeyEvent'
unix.o: In function `type_key':
/tmp/buildd/cellwriter-1.0.0/src/unix.c:59: undefined reference to
`XTestFakeKeyEvent'
/tmp/buildd/cellwriter-1.0.0/src/unix.c:60: undefined reference to
`XTestFakeKeyEvent'
unix.o: In function `key_event_send':
/tmp/buildd/cellwriter-1.0.0/src/unix.c:206: undefined reference to
`XTestFakeKeyEvent'
/tmp/buildd/cellwriter-1.0.0/src/unix.c:209: undefined reference to
`XTestFakeKeyEvent'
collect2: ld returned 1 exit status
make[2]: *** [cellwriter] Error 1
make[2]: Leaving directory `/tmp/buildd/cellwriter-1.0.0'
make[1]: *** [all] Error 2
make[1]: Leaving directory `/tmp/buildd/cellwriter-1.0.0'
make: *** [debian/stamp-makefile-build] Error 2
pbuilder: Failed autobuilding of package

Looks like you forgot to build-depend on x11proto-xext-dev. Please
check your package builds in a clean chroot before asking for a
sponsor (use sbuild/pbuilder/cowbuilder/qemubuilder or for that).

As upstream, you should fix these gcc warnings:

src/cellwidget.c: In function 'pack_cells':
src/cellwidget.c:544: warning: 'break_j' may be used uninitialized in
this function
src/cellwidget.c:544: note: 'break_j' was declared here

src/preprocess.c: In function 'greedy_map':
src/preprocess.c:84: warning: 'best_j' may be used uninitialized in
this function
src/preprocess.c:84: warning: 'last_j' may be used uninitialized in
this function
src/preprocess.c:82: warning: 'penalty' may be used uninitialized in
this function
src/preprocess.c:82: warning: 'best_value' may be used uninitialized
in this function
src/preprocess.c:82: warning: 'best_reach' may be used uninitialized
in this function

Thankyou for creating this software and for packaging it for Debian.

-- 
bye,
pabs

http://wiki.debian.org/PaulWise



Reply to: