[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: metacam (updated package)

On Mon, Aug 20, 2007 at 01:40:51PM -0400, Juan Angulo Moreno wrote......
> I am looking for a sponsor for the new version 1.2-4 of my package
> "metacam".
> http://mentors.debian.net/debian/pool/main/m/metacam/metacam_1.2-4.dsc

A few comments:

debian/compat: update to 5

    indent the Homepage line with two spaces and remove the blank
    line after the Homepage line

    Add ${misc:Depends} to Depends

debian/copyright: needs to be expanded to capture all authors and
copyrights. For example, the file casiotags.cc has:

    Copyright (C) 2000 Daniel Stephens (daniel@cheeseplant.org)
    Copyright (C) 2001, Jan Brittenson (bson@rockgarden.net)
    Copyright (C) 2001, Patrick Tullmann (pat@tullmann.org)

See the copyright of the package photon for an example of how to
structure a copyright file for multiple authors spread across
several different files.

Mention to upstream that they have the old, incorrect address for
the FSF in most all of their files. Run the command

    licensecheck -r .

from the working directory to see what I mean.

How was Bug #279342 fixed? It is not apparent from the changelog,
and running interdiff between the diff files doesn't show anything
new in that respect.

Otherwise looks fine.


Kevin Coyner  GnuPG key: 1024D/8CE11941

Reply to: