Re: RFS: kicad (updated package)
On 6/14/07, Richard A Burton <richardaburton@gmail.com> wrote:
kicad - Electronic schematic and PCB design software
A drive-by diff review:
Perhaps add descriptions and your name to the dpatches.
Have you sent the patches and the .desktop file upstream?
is 02_debpaths.dpatch really needed?
Might want to add the homepage to the package description[s]
${Source-Version} is obsolete, please use either ${binary:Version} or
${source:Version} (see http://wiki.debian.org/binNMU)
Why do only the german and italian help files depend on the english help files?
You can replace the patch/unpatch targets with an include
/usr/share/dpatch/dpatch.make
If it is possible to build the docs (which are probably arch-indep) in
the build-indep target, you should do that.
do you have a script to create the orig.tar.gz? you might want to add
a get-orig-source debian/rules target if so
IIRC, debian menu files can only use XPM icons because not all Debian
window managers support PNG
Does upstream not have a make install target? If not, perhaps you
could craft one and send it upstream, or get them to use automake or
some other system that does installs.
For the changelog, I suggest merging the unreleased changelog entry,
giving something like:
kicad (0.0.20070525-1) unstable; urgency=low
* New upstream release (Closes: #423873)
* Patch for the 3D Display image export problem (Closes: #423882)
* Install help files to correct location (Closes: #404783)
* For languages without native help files the English doc package is pulled in
with the non-English doc package, so there is at least some help.
* Not removing all binaries removed during 'clean' (Closes: #424455)
-- Richard A Burton <richardaburton@gmail.com> Sun, 27 May 2007 13:43:01 +0100
--
bye,
pabs
http://wiki.debian.org/PaulWise
Reply to: