Re: RFS: fspanel -- minimalist panel for X

[Daniel Baumann <daniel@debian.org>]

Jari Aalto wrote:
> http://cante.net/~jaalto/tmp/debian/fspanel/fspanel_0.7-7.dsc

  * If you fix the install procedure in the Makefile, do it right: use
    install -D so you first write the thing in less lines, and second,
    you can skip debian/dirs.

  * you use dh5, so bump compat to 5.

  * add ${misc:Depends} to Depends:.

  * the homepage entry should have *two* leading spaces.

  * the removal of configure-stamp in clean: is bogus, and the removal
    of build-stamp is wrong since you altered build-stamp: to touch it
    in debian/.

  * $(MAKE) install DESTDIR=`pwd`/debian/fspanel

    -> do *not* use `pwd`, but $(CURDIR).

  * behind dh_changelogs, there is a useless whitespace.

the rest is fine, if you fix above things, i'll sponsor the package.

-- 
Address:        Daniel Baumann, Burgunderstrasse 3, CH-4562 Biberist
Email:          daniel.baumann@panthera-systems.net
Internet:       http://people.panthera-systems.net/~daniel-baumann/