Re: RFS: fbxkb
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hi, Vadim,
- -=| Vadim Vatlin, 11.01.2007 22:41 |=-
> * Package name : fbxkb
> Version : 0.6-1
> Upstream Author : Anatoly Asviyan <aanatoly@users.sf.net>
> * URL : http://fbxkb.sf.net
> * License : GPL like
> Section : x11
>
> It builds these binary packages:
> fbxkb - X11 keyboard indicator and switcher
>
> The package can be found on mentors.debian.net:
> - URL: http://mentors.debian.net/debian/pool/main/f/fbxkb
>
> I would be glad if someone uploaded this package for me.
I can't sponsor the package, but I have some small comments (some of
which may well be wrong).
* You seem to heavily patch the manpage. The original manpage looks like
it is taken from another binary (fbpanel). Please remember to send
changes upstream.
* You don't invoke "make clean" in your debian/rules' clean target. To
see why this is bad, try building the package twice with
dpkg-buildpackage (not pbuilder).
* config.h is included in the diff, although it is generated as part of
the build process. It'd be better if you simply remove in the clean
target of debian/rules (and send patch upstream so "make clean" does
this too)
* Why do you build-depend on autotools-dev? I see to auto* usage in
debian/rules - just simple ./configure; make. Did you try building the
package with pbuilder without autotools-dev?
Overall I'd be very glad to see this package in Debian and use it.
Gnome's keyboard applet uses layout names instead of flags and this
makes it hard to quickly see what is the active layout.
Kind regards,
dam
- --
Damyan Ivanov Modular Software Systems
dam@modsoftsys.com
phone +359(2)928-2611, 929-3993 fax +359(2)920-0994
mobile +359(88)856-6067 dam@jabber.minus273.org/Gaim
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFFpq4YHqjlqpcl9jsRAtk5AJsElTxeVFcC0yn+F4DPsfXmkaqQhACfUkIq
5En1nd8VetQbq2Kr3WFaXU4=
=dUQj
-----END PGP SIGNATURE-----
Reply to: