Re: RFS: Cutecom
Roman I Khimov wrote:
> $ dget http://roman.khimov.ru/temp/deb-cutecom/cutecom_0.14.1-2_i386.changes
* changelog has a useless empty line at the end of the file
* you are modifying CMakeLists.txt, please not that and the reason in
changelog
* assumed that your package was not widely used amongst other users,
it doesn't make sense to keep old changelog entries when the package
was not uploaded. please merge them into one single entry for the
current version.
* cmake (>=2.4.3) should be cmake (>= 2.4.3)
(note the additional space)
* copyright has a useless empty line at the end of the file.
* remove the useless commented stuff in the manpage
* you install REAMDE through docs, but it doesn't contain any usefull
information.
* this is ugly:
---snipp---
#! /bin/sh /usr/share/dpatch/dpatch-run
---snapp---
this is beautiful:
---snipp---
#!/bin/sh /usr/share/dpatch/dpatch-run
---snapp---
* Remove the '## All lines beginning with `## DP:' are a description
of the patch.' lines from all dpatches
* dpatches are commonly named as ${number}-${name}.dpatch, e.g.
01-comparison-warning.dpatch and 02-iostream-include.dpatch.
* remove the useless comented stuff in rules.
* use patch-stamp, not patch to apply the dpatches.
* don't use two empty lines as seperator in rules, one is just enough.
* remove the useless commented stuff in watch.
the rest is good. if you fix above things, i'll sponsor the package.
--
Address: Daniel Baumann, Burgunderstrasse 3, CH-4562 Biberist
Email: daniel.baumann@panthera-systems.net
Internet: http://people.panthera-systems.net/~daniel-baumann/
Reply to: