Re: RFS: renrot - a program to rename and rotate files according to EXIF tags [andriy@asplinux.ru]
Thijs Kinkhorst wrote:
Description: A program to rename and rotate files according to EXIF tags
"A program to" is superfluous and should be removed.
Agree.
Renrot renames files according the DateTimeOriginal and FileModifyDate
EXIF tags, if they exist. Otherwise, the name will be set according to
the current timestamp. Additionally, it rotates files and their
thumbnails, accordingly Orientation EXIF tag.
"accordingly" -> "using the"
Agree also.
There's also the problem that your description does not contain
references to JPEG or photos. If I'm looking for "rotate" and "photo" or
"rotate" and "JPEG" I will not find it.
And should not find. I've explained bellow.
I propose the following revised short- and long description:
Description: Rename and rotate photos according to EXIF tags
Renrot renames JPEG files according the DateTimeOriginal and
FileModifyDate EXIF (metadata) tags, if they exist. Otherwise, the name
will be set according to the current timestamp. Additionally, it
rotates images and their thumbnails, using the Orientation EXIF tag.
These information is almost truth, except one: RenRot renames any file
with EXIF information (all types that exiftool supports) or without
(here is broken call). But rotating process is possible only for JPEG
files now. Thus, JPEG word should be moved to the last sentence like
"Additionally, it rotates JPEG images ..." and "photos" word should be
changed back to "files" in the brief description line.
* In debian/watch, replace "update" with "uupdate".
Done
* In debian/rules, you call the distclean target but your upstream
makefile doesn't contain that target.
Upstream has Makefile.PL that not real Makefile.
The passed Makefile.PL after perl call is contained following code:
# --- MakeMaker dist_basics section:
distclean :: realclean distcheck
$(NOECHO) $(NOOP)
P.S. Thanks for notices.
I've updated package. the .dsc URL is
ftp://andriy.asplinux.com.ua/pub/people/andy/renrot/Debian/renrot_0.25-1.dsc
--
With best regards,
Andy Shevchenko. mailto: andriy@asplinux.ru
Reply to: