Re: RFS: blacs-pvm (updated package)
On (25/09/06 20:53), Muammar Wadih El Khatib Rodriguez wrote:
> Dear mentors,
>
> I am looking for a sponsor for the new version 1.1-17
> of my package "blacs-pvm".
Hi,
I cannot sponsor, but I have some comments for you.
* Should the package names be prefixed with lib?
* blacs1-pvm.postinst is useless, as that will be added by
dh_makeshlibs
* Please drop the use of ${Source-Version}, see
http://lists.debian.org/debian-mentors/2006/09/msg00228.html
* The short descriptions are all lacking in my opinion
Basic Linear Algebra Comm. Subprograms - Dev. files for PVM
doesn't give much indication of what the package is for.
* The convention is to indent Homepage: by two spaces, see
http://www.debian.org/doc/manuals/developers-reference/ch-best-pkging-practices.en.html#s-bpp-upstream-info
* It would be good if the license informtion could be included in the
package itself. At any rate I think it would help to make it clearer
what is going on the the debian/copyright file. You should state
that you enquired by email and got that response.
Also there is no copyright information in that file, there is only
license information wrongly labelled as copyright information. See
http://lists.debian.org/debian-devel-announce/2006/03/msg00023.html
* Why do you clean at the start of all your build targets? That is
what the clean target is for, and is messy.
* Please add a watch file.
* There is an important linda warning
W: blacs1-pvm; The library libblacs is not in a shlibs file.
James
--
James Westby -- GPG Key ID: B577FE13 -- http://jameswestby.net/
seccure key - (3+)k7|M*edCX/.A:n*N!>|&7U.L#9E)Tu)T0>AM - secp256r1/nistp256
Reply to: