On August 23, 2006 at 11:45PM +0900,
nqm08501 (at nifty.com) wrote:
> Hi mentors,
>
> I'm looking for a sponsor for the "quilt-el" package. I sent RFS mail
> about one month ago, but unfortunately I haven't found sponsor yet...
> So I resend this mail. Could anyone review and upload this package?
>
> * Package name : quilt-el
> Version : 0.4-hg20060425-1
> Upstream Author : Matt Mackall <mpm@selenic.com>
> * URL : http://www.selenic.com/repo/quilt-el
> * License : GPL
> Description : a simple Emacs interface of quilt
>
> This package is linda and lintian clean, and can be downloaded from
> following URL:
>
> http://stakeuchi.sakura.ne.jp/deb/quilt-el
I've skimed through the source file and installed the package.
Here's some comments:
debian/copyright:
| Upstream Author: Matt Mackall <mpm@selenic.com>
Please add the copyright statement of the author mentioned in the source:
Copyright 2005 Matt Mackall <mpm@selenic.com>
| Copyright: GPL(see /usr/share/common-licenses/GPL)
GPL is a license, not a copyright. Please replace `Copyright' with
`License'.
debian/control:
| Description: a simple Emacs interface of quilt
It should not begin with an article, either definite ("the") or
indefinite ("a" or "an"). See also "Developer's Reference" section
6.2.2.
| .
| Homepage: http://www.selenic.com/repo/quilt-el
Please add a space to the beginning of `Homepage:'. See also
"Developer's Reference" section 6.2.4.
debian/emacsen-startup:
| (when (file-directory-p package-dir)
| (setq load-path (cons package-dir load-path)))
The debian-pkg-add-load-path-item function must be used to set
load-path in emacsen-startup. See also
`/usr/share/doc/emacsen-common/debian-emacs-policy.gz'.
debian/emacsen-install:
At byte-compile time, many startup files are loaded redundantly.
Please add "-no-site-file" to not load the startup files. Also,
please make *.el symlinks to find the source file from Emacs Help.
See the following patch:
----
--- quilt-el-0.4-hg20060425-1/debian/emacsen-install
+++ quilt-el-0.4-hg20060425/debian/emacsen-install
@@ -12,6 +12,7 @@
echo install/${PACKAGE}: Handling install for emacsen flavor ${FLAVOR}
+SITEFLAG="-no-site-file"
FLAGS="${SITEFLAG} -q -batch -l path.el -f batch-byte-compile"
ELDIR=/usr/share/emacs/site-lisp/${PACKAGE}
@@ -20,6 +21,7 @@
install -m 755 -d ${ELCDIR}
cd ${ELDIR}
FILES=`echo *.el`
+rm -f ${ELCDIR}/*.el
cp ${FILES} ${ELCDIR}
cd ${ELCDIR}
@@ -28,5 +30,8 @@
EOF
${FLAVOR} ${FLAGS} ${FILES}
rm -f *.el path.el
+for i in ${FILES}; do
+ ln -fs ${ELDIR}/$i
+done
exit 0
----
quilt.el:
| (define-key quilt-mode-map "\C-cqt" 'quilt-top)
[...]
| (define-key quilt-mode-map "\C-cqs" 'quilt-edit-series)
The key sequences `C-c' followed by ordinary letters (alphabet) are
reserved for users. The key sequences bound in a minor mode should
consist of `C-c' followed by a punctuation character other than
`{', `}', `<', `>', `:', and `;'. See also "GNU Emacs Lisp
Reference Manual" (info Elisp).
BTW, I'm not a user of quilt, but I can sponsor your package.
If no one has offered to sponsor it for you, please mail me
(in Japanese or English).
--
Tatsuya Kinoshita
Attachment:
pgpEKwLXj6Pn1.pgp
Description: PGP signature