[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: sitebar (updated package)



On (29/07/06 21:55), George Danchev wrote:
> On Saturday 29 July 2006 21:41, James Westby wrote:
> > On (29/07/06 14:14), Kevin Coyner wrote:
> > > Please note that at mentors.debian.net it does throw off a lintian
> > > warning:
> > >
> > > W: sitebar source: build-depends-without-arch-dep
> > >     Build-Depends: debhelper (>=5.0), po-debconf
> >
> > I have this problem with one of my Arch: all packages. Do you use -i to
> > lintian, it explains it quite well.
> >
> > For Arch: all packages do not have any binary targets used, and so do
> > not require arch-dependent stuff, and as such everything can be in
> > B-D-I.
> >
> > However, B-D-Is are not satisfied if you run the clean target. You
> > probably use dh_clean in your clean target, and as such need debhelper
> > in B-D. There is therefore an exception for debhelper in lintian.
> >
> > Now, in po-debconf(7) it suggests putting debconf-updatepo in the clean
> > target, which I assume you have done. (If not then the rest of the
> > discussion doesn't really apply). Now it is used in clean it needs to be
> > in B-D for the reasons explained above. The problem is that lintian does
> > not have the exception built in for po-debconf.
> >
> > Nowm debhleper depends on po-debconf, so you can get away with removing
> > the explicit depenency, but I think this is wrong.
> >
> > I think the fix is to patch lintian to catch this situation and ignore it.
> >
> > If someone will confirm that I am correct I will file a bug against
> > lintian to do this.
> 
> Seems like -mentors is running old version of lintian, since this has been 
> dealt with, see: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=321135
> 

That doesn't deal with po-debconf apparently, and I am seeing this problem 
here as well.

The patch below is what I think the fix would be. The lintian maintainer(s) have done the hard work, it's just adding another case.

James

--- checks/fields.orig  2006-07-29 19:45:28.000000000 +0100
+++ checks/fields       2006-07-29 20:11:54.000000000 +0100
@@ -80,6 +80,7 @@
 my @rule_clean_depends = (
        [ debhelper => '^\t\s*dh_.+' ],
        [ dpatch => '^\t\s*dpatch\s' ],
+       [ "po-debconf" => '^\t\s*debconf-updatepo\s' ],
        [ $python_depend => '^\t\s*python\s' ],
        [ quilt => '^\t\s*(\S+=\S+\s+)*quilt\s' ],
        [ yada => '^\t\s*yada\s' ],

-- 
  James Westby
  jw+debian@jameswestby.net
  http://jameswestby.net/



Reply to: