Le mardi 25 avril 2006 à 11:20 +0800, Paul Wise a écrit : > On Mon, 2006-04-24 at 23:48 +0200, Le_Vert wrote: > > > spcaview : package review needed > > The convention is RFC: package -- package description > > > http://www.le-vert.net/divers/debian-package/spcaview/spcaview_20051212-1.dsc > > Best to just specify the dsc/diff so we can go dget -x <url.dsc> for a > more thorough review, or open it in a browser for a quick one. > > > Could you check this package before my sponsor upload it ? : > > Some comments: > > * hopefully your sponsor will check it too ;) He is, but as he has no video device he can't check if everything is working... > * debian/changelog: the version should be 0.0.20051212 or > 0.0.0.20051212 or something so that if upstream changes their > version scheme, you won't have to use and epoch. Fixed. > * debian/control: might want to add the Homepage. see the devref > 6.2.4 for how Fixed. > . > * debian/compat: might want to consider dropping to 4 if you don't > use any debhelper 5 features (makes things slightly easier for > sarge backporters) Downgraded. > * debian/control: package description could use some work, esp > grammar. consult either this list or the debian-l10n-english > list if english is not your first language. Also, check policy, > the devref and [1] for some helpful tips for descriptions. I did my best... I hope it's better now, I'm not a nativ english speaker. > * debian/copyright: you miss the authors and some of the > copyrights, please read [2] and check them with mc and grep -rih > copyright . | sort -u I added everything I can find in any sources files. > * debian/rules: better to use quilt/dpatch than a homebrew patch > system I'm using dpatch right now, pretty nice, thanks :-) > * debian/rules: you can use debian/manpages instead of passing > arguments to dh_installman Fixed. > * debian/watch: please add one (read uscan(1) for more info) Added. Looks great but is it usefull ? Can I receive an e-mail when my package is no more up to date ? > * debian/patches and debian/manpages: don't forget to send these > to upstream (except changing the BIN variable, upstream should > use /usr/local) It'll be done. > * http-java-applet/install should probably get installed as a doc. > http-java-applet/index-sample.html and > http-java-applet/control.jpg should probably be installed using > dh_installexamples > * orig.tar.gz: http-java-applet/JWebcamPlayer.jar contains > compiled bytecode, it *must not* be shipped (and probably should > be removed from the orig.tar.gz). You should recompile it using > free java if possible. If not, ask on the debian-java list, or > possibly the classpath developers for help porting it. > * orig.tar.gz: what is the copyright/licence for SwingWorker.java? > looks like a copy of [3]. If so, that would be copyright by sun > and not distributable. Removed all of it from sources. Doesn't work, no copyright information and this is really not related to spcaview tools anyway. > * orig.tar.gz: please remove the build/install instructions from > the README (since debian users don't need them), and ask > upstream to split those out into INSTALL. Fixed. > * lintian/linda: give these errors: > > E: spcaview source: debian-rules-missing-required-target binary-indep > N: > N: The debian/rules file for this package does not provide one of the > N: required targets. All of build, binary, binary-arch, binary-indep, and > N: clean must be provided, even if they don't do anything for this > N: package. > N: > N: Refer to Policy Manual, section 4.8 for details. > N: > W: spcaview; A binary links against a library it does not use symbols from > This package contains a binary that links against a library that is > not in the Depends line. This may also be a bug in the library which > does not have a shlibs file. Binary-indep rule added. What's about the second one ? My lintian doesn't give this warning (Etch). > > 1. http://people.debian.org/~walters/descriptions.html > 2. http://lists.debian.org/debian-devel-announce/2006/03/msg00023.html > 3. http://java.sun.com/products/jfc/tsc/articles/threads/src/SwingWorker.java > Thanks ! I guess the package is really far better now... Any other suggestions ? http://www.le-vert.net/divers/debian-package/spcaview/
Attachment:
signature.asc
Description: Ceci est une partie de message =?ISO-8859-1?Q?num=E9riquement?= =?ISO-8859-1?Q?_sign=E9e?=