Hello,
Am Montag, 20. Februar 2006 02:43 schrieb Simon Richter:
> Hendrik Sattler schrieb:
> > The new package can be found at:
> > http://www.stud.uni-karlsruhe.de/~ubq7/debian/
> >
> > The source package got renamed (libopenobex1.0 -> libopenobex) as it was
> > once (in oldstable) and the binary packages got renamed, too
> > (libopenobex-1.0-0 -> libopenobex1). The naming is thus consistent with
> > the libpkg-guide.
>
> Is the API/ABI sufficiently stable? I see that the Debian patch
> introduces a new parameter to a function.
This is inside the apps/ subdirectory which is not part of the lib. The patch
was already in the openobex-apps package and I took it over since it still
applies. The referring changelog entry from openobex-apps:
* Apply patch to enable control of creator ID with irobex_palm3.
Thanks to Bruno David Rodrigues. (Closes: #185833)
That leaves the question if the previously seperated changelogs should be
included?
Intention was to leave package in there current state and address the
presently filed bugs after the first upload.
> > I also notified the maintainer of ircp but did not get any answer so far.
> > However, I included any patches of the previously seperated packages. The
> > patches are handled by quilt (no build-time patching).
>
> There are two issues I have with that:
>
> 1. If it's going to end up in a separate package anyway, there is no
> point in pulling in source code from other projects as a patch.
I didn't but upstream did. Previously, upstream seperated the source in three
packages but gave up on that with the current release (it is a configure
parameter now to build the apps).
> I believe this to be too broad a change for a simple package. If it is a
> separate project, it is a separate package. If it is not, it should be
> contained in the upstream source already (on the very extreme side of
> that, when I packaged spandsp I packaged the library on its own and
> added the "example" code, a bunch of asterisk plugins, by creating a
> tarball from the loose files that were on the author's website).
It is already in the upstream source. See
http://sourceforge.net/project/showfiles.php?group_id=8960&package_id=9047
and compare versions 1.1 and 1.0 (1.0.1 was not packaged).
> 2. Every file that is added is contained three times in the diff (look
> at the diffstat output), once for quilt's hidden directory, once for
> debian/patches and once for the actual file being patched.
Other DDs told me that shipping the seperated patches with the package is
actually wanted. That leaves only one more copy in the .pc subdir. However,
deleting it means that if someone else works on an additional patch, he has to
re-do all previous ones (as that is how quilt works).
Thus the only "fix" would be to not use quilt at all.
> Also, there still are a number of lintian warnings.
W: openobex-apps: binary-without-manpage irobex_palm3
W: openobex-apps: binary-without-manpage irxfer
W: openobex-apps: binary-without-manpage obex_tcp
W: openobex-apps: binary-without-manpage obex_test
Those are mentioned in the TODO file of that package. It needs some work,
sure. If you require that before first upload, then I'll do that. However,
I'd rather move that to -2.
W: openobex-apps: old-fsf-address-in-copyright-file
W: libopenobex1-dev: old-fsf-address-in-copyright-file
W: libopenobex1: old-fsf-address-in-copyright-file
W: ircp: old-fsf-address-in-copyright-file
That should be changed before uploading....done.
A new version of the 1.1-1 is available.
What about the linda-warning?:
W: libopenobex; Paketversion 1.1-1 ist geringer als 1:1.0.0-rel-3.
I was under the assumption that I don't have to take the epoch over to the new
package (binary package names are different, source package name is
different). However, the linda test may be broken.
> > I hope that someone can sponsor this new version; getting obexftp-0.19
> > also uploaded would be a bonus :)
>
> I could see a bit of merit in getting this package into unstable sooner
> than later, to allow the depending packages to adapt and bugs be ironed
> out before the release. As I don't see any policy violations or
> regressions from a quick glimpse over the package, I might be persuaded
> to upload this still (after a more thorough check) and file bugs for the
> issues remaining.
Great. Don't miss the updated version (note: package version did not change!).
> > I also plan on packaging other OBEX related packages, e.g. wnpp bug
> > #238314.
>
> Are you by chance interested in taking over ussp-push as well?
I am not sure as obexftp can do the same thing by now (and qobex, too) when
using no uuid. However, I'll take a look at it, maybe there's more to it than
the description says.
HS
Attachment:
pgpWAofQcq1Ct.pgp
Description: PGP signature